Disallow quotes in file-level directives

src/Cli/dotnet/Commands/CliCommandStrings.resx

@@ -1620,6 +1620,9 @@ Tool '{1}' (version '{2}') was successfully installed. Entry is added to the man
     <value>Duplicate directives are not supported: {0}</value>
     <comment>{0} is the directive type and name.</comment>
   </data>
+  <data name="QuoteInDirective" xml:space="preserve">
+    <value>Directives currently cannot contain double quotes (").</value>
+  </data>
   <data name="InvalidOptionForStdin" xml:space="preserve">
     <value>Cannot specify option '{0}' when also using '-' to read the file from standard input.</value>
     <comment>{0} is an option name like '--no-build'.</comment>

src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs

@@ -1505,8 +1505,15 @@ public static ImmutableArray<CSharpDirective> FindDirectives(SourceFile sourceFi
                     Diagnostics = diagnostics,
                     SourceFile = sourceFile,
                     DirectiveKind = name.ToString(),
-                    DirectiveText = value.ToString()
+                    DirectiveText = value.ToString(),
                 };
+
+                // Block quotes now so we can later support quoted values without a breaking change. https://github.com/dotnet/sdk/issues/49367
+                if (value.Contains('"'))
+                {
+                    diagnostics.AddError(sourceFile, context.Info.Span, CliCommandStrings.QuoteInDirective);
+                }
+
                 if (CSharpDirective.Parse(context) is { } directive)
                 {
                     // If the directive is already present, report an error.

test/dotnet.Tests/CommandTests/Project/Convert/DotnetProjectConvertTests.cs

@@ -1,6 +1,7 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Collections.Immutable;
 using System.Security;
 using System.Text.RegularExpressions;
 using Microsoft.CodeAnalysis.Text;
@@ -1168,10 +1169,10 @@ public void Directives_InvalidPropertyName()
     {
         VerifyConversionThrows(
             inputCSharp: """
-                #:property Name"=Value
+                #:property 123Name=Value
                 """,
             expectedWildcardPattern: RunFileTests.DirectiveError("/app/Program.cs", 1, CliCommandStrings.PropertyDirectiveInvalidName, """
-                The '"' character, hexadecimal value 0x22, cannot be included in a name.
+                Name cannot begin with the '1' character, hexadecimal value 0x31.
                 """));
     }
 
@@ -1198,11 +1199,14 @@ public void Directives_Escaping()
         VerifyConversion(
             inputCSharp: """
                 #:property Prop=<test">
-                #:sdk <test"> @="<>test
-                #:package <test"> @="<>test
+                #:sdk <test"> @="<>te'st
+                #:package <te'st"> @="<>te'st
+                #:property Pro'p=Single'
+                #:property Prop2=\"Value\"
+                #:property Prop3='Value'
                 """,
             expectedProject: $"""
-                <Project Sdk="&lt;test&quot;&gt;/=&quot;&lt;&gt;test">
+                <Project Sdk="&lt;test&quot;&gt;/=&quot;&lt;&gt;te&apos;st">
 
                   <PropertyGroup>
                     <OutputType>Exe</OutputType>
@@ -1212,16 +1216,29 @@ public void Directives_Escaping()
                     <PublishAot>true</PublishAot>
                     <PackAsTool>true</PackAsTool>
                     <Prop>&lt;test&quot;&gt;</Prop>
+                    <Prop2>\&quot;Value\&quot;</Prop2>
+                    <Prop3>&apos;Value&apos;</Prop3>
                   </PropertyGroup>
 
                   <ItemGroup>
-                    <PackageReference Include="&lt;test&quot;&gt;" Version="=&quot;&lt;&gt;test" />
+                    <PackageReference Include="&lt;te&apos;st&quot;&gt;" Version="=&quot;&lt;&gt;te&apos;st" />
                   </ItemGroup>
 
                 </Project>
 
                 """,
-            expectedCSharp: "");
+            expectedCSharp: """
+                #:property Pro'p=Single'
+
+                """,
+            expectedErrors:
+            [
+                (1, CliCommandStrings.QuoteInDirective),
+                (2, CliCommandStrings.QuoteInDirective),
+                (3, CliCommandStrings.QuoteInDirective),
+                (4, string.Format(CliCommandStrings.PropertyDirectiveInvalidName, "The ''' character, hexadecimal value 0x27, cannot be included in a name.")),
+                (5, CliCommandStrings.QuoteInDirective),
+            ]);
     }
 
     [Fact]
@@ -1257,7 +1274,11 @@ public void Directives_Whitespace()
                  #  !  /test
                   #!  /program   x   
                  # :property Name=Value
-                """);
+                """,
+            expectedErrors:
+            [
+                (3, CliCommandStrings.QuoteInDirective),
+            ]);
     }
 
     [Fact]
@@ -1548,10 +1569,15 @@ public void Directives_VersionedSdkFirst()
                 """);
     }
 
-    private static void Convert(string inputCSharp, out string actualProject, out string? actualCSharp, bool force, string? filePath)
+    private const string programPath = "/app/Program.cs";
+
+    private static void Convert(string inputCSharp, out string actualProject, out string? actualCSharp, bool force, string? filePath,
+        bool collectDiagnostics, out ImmutableArray<SimpleDiagnostic>.Builder? actualDiagnostics)
     {
-        var sourceFile = new SourceFile(filePath ?? "/app/Program.cs", SourceText.From(inputCSharp, Encoding.UTF8));
-        var directives = VirtualProjectBuildingCommand.FindDirectives(sourceFile, reportAllErrors: !force, DiagnosticBag.ThrowOnFirst());
+        var sourceFile = new SourceFile(filePath ?? programPath, SourceText.From(inputCSharp, Encoding.UTF8));
+        actualDiagnostics = null;
+        var diagnosticBag = collectDiagnostics ? DiagnosticBag.Collect(out actualDiagnostics) : DiagnosticBag.ThrowOnFirst();
+        var directives = VirtualProjectBuildingCommand.FindDirectives(sourceFile, reportAllErrors: !force, diagnosticBag);
         var projectWriter = new StringWriter();
         VirtualProjectBuildingCommand.WriteProjectFile(projectWriter, directives, isVirtualProject: false);
         actualProject = projectWriter.ToString();
@@ -1561,25 +1587,43 @@ private static void Convert(string inputCSharp, out string actualProject, out st
     /// <param name="expectedCSharp">
     /// <see langword="null"/> means the conversion should not touch the C# content.
     /// </param>
-    private static void VerifyConversion(string inputCSharp, string expectedProject, string? expectedCSharp, bool force = false, string? filePath = null)
+    private static void VerifyConversion(string inputCSharp, string expectedProject, string? expectedCSharp, bool force = false, string? filePath = null,
+        IEnumerable<(int LineNumber, string Message)>? expectedErrors = null)
     {
-        Convert(inputCSharp, out var actualProject, out var actualCSharp, force: force, filePath: filePath);
+        Convert(inputCSharp, out var actualProject, out var actualCSharp, force: force, filePath: filePath,
+            collectDiagnostics: expectedErrors != null, out var actualDiagnostics);
         actualProject.Should().Be(expectedProject);
         actualCSharp.Should().Be(expectedCSharp);
+        VerifyErrors(actualDiagnostics, expectedErrors);
     }
 
     private static void VerifyConversionThrows(string inputCSharp, string expectedWildcardPattern)
     {
-        var convert = () => Convert(inputCSharp, out _, out _, force: false, filePath: null);
+        var convert = () => Convert(inputCSharp, out _, out _, force: false, filePath: null, collectDiagnostics: false, out _);
         convert.Should().Throw<GracefulException>().WithMessage(expectedWildcardPattern);
     }
 
     private static void VerifyDirectiveConversionErrors(string inputCSharp, IEnumerable<(int LineNumber, string Message)> expectedErrors)
     {
-        var programPath = "/app/Program.cs";
         var sourceFile = new SourceFile(programPath, SourceText.From(inputCSharp, Encoding.UTF8));
         VirtualProjectBuildingCommand.FindDirectives(sourceFile, reportAllErrors: true, DiagnosticBag.Collect(out var diagnostics));
-        Assert.All(diagnostics, d => { Assert.Equal(programPath, d.Location.Path); });
-        diagnostics.Select(d => (d.Location.Span.Start.Line + 1, d.Message)).Should().BeEquivalentTo(expectedErrors);
+        VerifyErrors(diagnostics, expectedErrors);
+    }
+
+    private static void VerifyErrors(ImmutableArray<SimpleDiagnostic>.Builder? actual, IEnumerable<(int LineNumber, string Message)>? expected)
+    {
+        if (actual is null)
+        {
+            Assert.Null(expected);
+        }
+        else if (expected is null)
+        {
+            Assert.Null(actual);
+        }
+        else
+        {
+            Assert.All(actual, d => { Assert.Equal(programPath, d.Location.Path); });
+            actual.Select(d => (d.Location.Span.Start.Line + 1, d.Message)).Should().BeEquivalentTo(expected);
+        }
     }
 }