Skip to content

Fix SWID tag #51138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/10.0.1xx
Choose a base branch
from
Open

Fix SWID tag #51138

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69d4588
Fix SWID tag
joeloff Oct 6, 2025
8704d51
Fix typo
joeloff Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Layout/pkg/windows/bundles/sdk/bundle.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@
<Payload Name="dotnet.ico" Compressed="yes" SourceFile="..\..\dotnet.ico" />
</BootstrapperApplication>

<SoftwareTag Regid="microsoft.com" InstallPath="[ProgramFiles6432Folder]dotnet" />
<!-- Do not use ProgramFiles6432Folder. It defaults to CSIDL_PROGRAM_FILES and will write
the tag to Program Files when installing the x86 SDK on 64-bit OS. -->
<?if $(TargetArchitecture)~=x86?>
<SoftwareTag Regid="microsoft.com" InstallPath="[ProgramFilesFolder]dotnet" />
<?else?>
<SoftwareTag Regid="microsoft.com" InstallPath="[ProgramFiles64Folder]dotnet]" />
Copy link
Member

@merriemcgaw merriemcgaw Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need the extra ] after dotnet the end of the line here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that.

<?endif?>

<!-- Search references for upgrade policy keys -->
<util:RegistrySearchRef Id="RemovePreviousVersionRegistryKeySearch"/>
Expand Down
Loading