Refactor Tool and Workload command subcommands - separate parsing and action logic #52162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 15, 2025
… action logic Co-authored-by: tmat <41759+tmat@users.noreply.github.com>
tmat
force-pushed
the
WorkloadToolCmds
branch
2 times, most recently
from
eb41520 to
602cad1
Compare
This was referenced Dec 27, 2025
tmat
force-pushed
the
WorkloadToolCmds
branch
from
4911b1c to
641981f
Compare
tmat
force-pushed
the
WorkloadToolCmds
branch
2 times, most recently
from
99055c6 to
d6a9746
Compare
This was referenced Dec 29, 2025
Member
Author
|
@MiYanni ptal |
MiYanni
reviewed
Jan 5, 2026
|
|
||
| public readonly Option<int> TakeOption = new("--take") | ||
| { | ||
| DefaultValueFactory = (_) => 5 |
Member
There was a problem hiding this comment.
Is this magic number saying it'll return 5 items by default?
Member
Author
There was a problem hiding this comment.
I just moved the option definition, did not change the impl. Yeah, it seems to set the default value to 5.
MiYanni
approved these changes
Jan 5, 2026
Member
Author
|
/ba-g winrt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit implements the separation and was authored by copilot.
The second and third commits switch from static option fields to instance fields for all workload and tool commands and subcommands, following the pattern established by #52137.
The last commit updates test baselines to reflect new ordering of some options.