Fix detect-netsdk-diagnostics action false positives #53017
+19
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the detect-netsdk-diagnostics GitHub Action to avoid false positives when large .xlf changes exist on the target branch by ensuring the workflow only diffs the PR’s changes.
Changes:
- Switch
.xlfdiff generation from a two-dot diff (base..head) to a three-dot diff (base...head) so only PR-introduced changes are considered. - Merge the previously separate “Read .xlf Diff” and “Detect diagnostics” jobs into a single
detect-diagnosticsjob, passing the diff via step outputs.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…://github.com/MichaelSimons/sdk into fix-detect-netsdk-diagnostics-false-positives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53016
The `detect-netsdk-diagnostics` GitHub Action uses a two-dot diff (`base.sha..head.sha`) to compare `.xlf` files. This compares the tip of the target branch against the PR head, meaning if large `.xlf` changes exist on the base branch that the PR hasn't rebased onto, the diff includes those unrelated changes. This causes false positives when the diff exceeds the 1MB job output limit — failing PRs that don't even touch `.xlf` files.