Fix MTP message handling bugs in TestApplicationHandler#53303
Draft
Evangelink wants to merge 1 commit intomainfrom
Draft
Fix MTP message handling bugs in TestApplicationHandler#53303Evangelink wants to merge 1 commit intomainfrom
Evangelink wants to merge 1 commit intomainfrom
Conversation
- Fix copy-paste bug in OnSessionEventReceived: the exception for missing handshake incorrectly used nameof(DiscoveredTestMessages) instead of nameof(TestSessionEvent), producing a misleading error message. - Add else clause to throw ArgumentOutOfRangeException for unknown SessionType values, consistent with the pattern used in ToOutcome(). Previously, unknown session types were silently ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in
TestApplicationHandler.OnSessionEventReceived:1. Copy-paste bug: wrong
nameofin exception messageThe exception for a missing handshake incorrectly used
nameof(DiscoveredTestMessages)instead ofnameof(TestSessionEvent), producing a misleading error message when aTestSessionEventis received before handshake.2. Unknown
SessionTypevalues silently ignoredIf a new session event type were added to the protocol, it would be silently dropped. Added an
elseclause to throwArgumentOutOfRangeExceptionfor unknown values, consistent with the pattern used inToOutcome()which also throws for unrecognized values.Changes
src/Cli/dotnet/Commands/Test/MTP/TestApplicationHandler.cs