Merged
Conversation
Member
Author
ericstj
reviewed
Apr 30, 2025
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: '8.0.x' | ||
| global-json-file: global.json |
ericstj
reviewed
Apr 30, 2025
Comment on lines
+25
to
+26
| <file src="BuildHost-net472\*.*" target="tools\BuildHost-net472" /> | ||
| <file src="BuildHost-netcore\*.*" target="tools\BuildHost-netcore" /> |
Member
There was a problem hiding this comment.
Do these need to be recursive? If I check microsoft.codeanalysis.workspaces.msbuild it does have some subfolders.
Member
Author
There was a problem hiding this comment.
I don't know but this is from the upstream: https://github.com/KirillOsenkov/SourceBrowser/blob/main/src/HtmlGenerator/SourceBrowser.nuspec so maybe fixes should go there first? I don't think we care much here anyway about this nuspec, we don't publish/consume this as nuget package.
ericstj
approved these changes
Apr 30, 2025
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
LGTM, thank you for fixing this 🙏
Member
Author
|
Feel free to merge when ready, I don't have permissions, thanks. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes most errors from #174 since the Roslyn version is updated from 4.2 to 4.12 (so there are no more parsing errors for modern features like collection expressions which can break reference links in the rest of the files). The one remaining error reported in #174 (for Application.SetHighDpiMode) is fixed by #183.
This PR is currently deployed at https://netsourceindex-validation.azurewebsites.net/ via this official build run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2698995&view=results