Merge pull request #3581 from WardenGnaw/dev/waan/checkPlatformAndArch

Add Error Message for Unsupported Platforms

Author: JoeRobich

.travis.yml

@@ -7,7 +7,7 @@ mono:
   - latest
 
 env:
-- CODE_VERSION=1.33.0
+- CODE_VERSION=1.36.0
 
 before_install:
   - if [ $TRAVIS_OS_NAME == "linux" ]; then

package.json

@@ -358,7 +358,7 @@
     }
   ],
   "engines": {
-    "vscode": "^1.31.0"
+    "vscode": "^1.36.0"
   },
   "activationEvents": [
     "onDebugInitialConfigurations",

src/main.ts

@@ -121,6 +121,32 @@ export async function activate(context: vscode.ExtensionContext): Promise<CSharp
         eventStream.post(new ActivationFailure());
     }
 
+    if (!isSupportedPlatform(platformInfo)) {
+        const platform: string = platformInfo.platform ? platformInfo.platform : "this platform";
+        const architecture: string = platformInfo.architecture ? platformInfo.architecture : " and <unknown processor architecture>";
+        let errorMessage: string = `The C# extension for Visual Studio Code (powered by OmniSharp) is incompatiable on ${platform} ${architecture}`;
+        const messageOptions: vscode.MessageOptions = {
+        };
+
+        // Check to see if VS Code is running remotely
+        if (extension.extensionKind === vscode.ExtensionKind.Workspace) {
+            const setupButton: string = "How to setup Remote Debugging";
+            errorMessage += ` with the VS Code Remote Extensions. To see avaliable workarounds, click on '${setupButton}'.`;
+
+            await vscode.window.showErrorMessage(errorMessage, messageOptions, setupButton).then((selectedItem: string) => {
+                if (selectedItem === setupButton) {
+                    let remoteDebugInfoURL = 'https://github.com/OmniSharp/omnisharp-vscode/wiki/Remote-Debugging-On-Linux-Arm';
+                    vscode.env.openExternal(vscode.Uri.parse(remoteDebugInfoURL));
+                }
+            });
+        } else {
+            await vscode.window.showErrorMessage(errorMessage, messageOptions);
+        }
+
+        // Unsupported platform
+        return null;
+    }
+
     let telemetryObserver = new TelemetryObserver(platformInfo, () => reporter);
     eventStream.subscribe(telemetryObserver.post);
 
@@ -171,6 +197,24 @@ export async function activate(context: vscode.ExtensionContext): Promise<CSharp
     };
 }
 
+function isSupportedPlatform(platform: PlatformInformation): boolean {
+    if (platform.isWindows()) {
+        return platform.architecture === "x86" || platform.architecture === "x86_64";
+    }
+
+    if (platform.isMacOS()) {
+        return true;
+    }
+
+    if (platform.isLinux()) {
+        return platform.architecture === "x86_64" ||
+               platform.architecture === "x86" ||
+               platform.architecture === "i686";
+    }
+
+    return false;
+}
+
 async function ensureRuntimeDependencies(extension: vscode.Extension<CSharpExtensionExports>, eventStream: EventStream, platformInfo: PlatformInformation, installDependencies: IInstallDependencies): Promise<boolean> {
     return installRuntimeDependencies(extension.packageJSON, extension.extensionPath, installDependencies, eventStream, platformInfo);
 }

src/platform.ts

@@ -191,6 +191,9 @@ export class PlatformInformation {
             if (process.env.PROCESSOR_ARCHITECTURE === 'x86' && process.env.PROCESSOR_ARCHITEW6432 === undefined) {
                 resolve('x86');
             }
+            else if (process.env.PROCESSOR_ARCHITECTURE === 'ARM64' && process.env.PROCESSOR_ARCHITEW6432 === undefined) {
+                resolve('ARM64');
+            }
             else {
                 resolve('x86_64');
             }

src/vscodeAdapter.ts

@@ -943,7 +943,7 @@ export interface vscode {
     };
     extensions: {
         getExtension(extensionId: string): Extension<any> | undefined;
-        all: Extension<any>[];
+        all: ReadonlyArray<Extension<any>>;
     };
     Uri: {
         parse(value: string): Uri;