Skip to content

Commit d5362bf

Browse files
dibarbetdibarbet
committed
use vscode-uri
1 parent 06460ea commit d5362bf

File tree

3 files changed

+23
-21
lines changed

3 files changed

+23
-21
lines changed

‎package-lock.json

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@
141141
"typescript": "4.6.3",
142142
"unzipper": "0.10.11",
143143
"vsce": "2.9.2",
144+
"vscode-uri": "^3.0.7",
144145
"webpack": "5.76.0",
145146
"webpack-cli": "4.6.0"
146147
},
@@ -856,17 +857,17 @@
856857
"items": {
857858
"type": "string"
858859
},
859-
"description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
860+
"description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
860861
"default": []
861862
},
862863
"searchMicrosoftSymbolServer": {
863864
"type": "boolean",
864-
"description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
865+
"description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
865866
"default": false
866867
},
867868
"searchNuGetOrgSymbolServer": {
868869
"type": "boolean",
869-
"description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
870+
"description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
870871
"default": false
871872
},
872873
"cachePath": {
@@ -1498,17 +1499,17 @@
14981499
"items": {
14991500
"type": "string"
15001501
},
1501-
"description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
1502+
"description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
15021503
"default": []
15031504
},
15041505
"csharp.debug.symbolOptions.searchMicrosoftSymbolServer": {
15051506
"type": "boolean",
1506-
"description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
1507+
"description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
15071508
"default": false
15081509
},
15091510
"csharp.debug.symbolOptions.searchNuGetOrgSymbolServer": {
15101511
"type": "boolean",
1511-
"description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
1512+
"description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
15121513
"default": false
15131514
},
15141515
"csharp.debug.symbolOptions.cachePath": {
@@ -2250,17 +2251,17 @@
22502251
"items": {
22512252
"type": "string"
22522253
},
2253-
"description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
2254+
"description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
22542255
"default": []
22552256
},
22562257
"searchMicrosoftSymbolServer": {
22572258
"type": "boolean",
2258-
"description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
2259+
"description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
22592260
"default": false
22602261
},
22612262
"searchNuGetOrgSymbolServer": {
22622263
"type": "boolean",
2263-
"description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
2264+
"description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
22642265
"default": false
22652266
},
22662267
"cachePath": {
@@ -2690,17 +2691,17 @@
26902691
"items": {
26912692
"type": "string"
26922693
},
2693-
"description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
2694+
"description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
26942695
"default": []
26952696
},
26962697
"searchMicrosoftSymbolServer": {
26972698
"type": "boolean",
2698-
"description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
2699+
"description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
26992700
"default": false
27002701
},
27012702
"searchNuGetOrgSymbolServer": {
27022703
"type": "boolean",
2703-
"description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
2704+
"description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
27042705
"default": false
27052706
},
27062707
"cachePath": {
@@ -3404,17 +3405,17 @@
34043405
"items": {
34053406
"type": "string"
34063407
},
3407-
"description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
3408+
"description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
34083409
"default": []
34093410
},
34103411
"searchMicrosoftSymbolServer": {
34113412
"type": "boolean",
3412-
"description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
3413+
"description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
34133414
"default": false
34143415
},
34153416
"searchNuGetOrgSymbolServer": {
34163417
"type": "boolean",
3417-
"description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
3418+
"description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
34183419
"default": false
34193420
},
34203421
"cachePath": {
@@ -3844,17 +3845,17 @@
38443845
"items": {
38453846
"type": "string"
38463847
},
3847-
"description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
3848+
"description": "Array of symbol server URLs (example: http​://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",
38483849
"default": []
38493850
},
38503851
"searchMicrosoftSymbolServer": {
38513852
"type": "boolean",
3852-
"description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
3853+
"description": "If 'true' the Microsoft Symbol server (https​://msdl.microsoft.com​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
38533854
"default": false
38543855
},
38553856
"searchNuGetOrgSymbolServer": {
38563857
"type": "boolean",
3857-
"description": "If 'true' the NuGet.org symbol server (https\u200b://symbols.nuget.org\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
3858+
"description": "If 'true' the NuGet.org symbol server (https​://symbols.nuget.org​/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.",
38583859
"default": false
38593860
},
38603861
"cachePath": {
@@ -4857,4 +4858,4 @@
48574858
}
48584859
]
48594860
}
4860-
}
4861+
}

‎test/unitTests/features/reportIssue.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6+
import { URI } from 'vscode-uri';
67
import { getFakeVsCode } from "../testAssets/Fakes";
78
import reportIssue from "../../../src/shared/reportIssue";
89
import { expect } from "chai";
@@ -54,8 +55,7 @@ suite(`${reportIssue.name}`, () => {
5455

5556
setup(() => {
5657
vscode = getFakeVsCode();
57-
// @ts-ignore
58-
vscode.Uri.parse = (value) => { return value; };
58+
vscode.Uri.parse = (value) => { return URI.parse(value); };
5959
vscode.env.openExternal = async (value) => {
6060
return Promise.resolve(true);
6161
};

0 commit comments

Comments
 (0)