Adding changes to support use monovsdbg to debug wasm apps. #7220

thaystg · 2024-06-10T16:04:02Z

Adding changes to support debug wasm apps using monovsdbg.

Tested scenarios with the new setting enabled and this PR:

With Assets and C# DevKit Not Installed targetting .NET 8 (Blazor Wasm) - DISABLED
With Assets and C# DevKit Not Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED
With Assets and C# DevKit Not Installed targetting .NET 9 (Blazor Wasm) - ENABLED
With Assets and C# DevKit Not Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED
With Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED
With Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - ENABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - ENABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED

Tested scenarios only updating C# DevKit with the monovsdbg support:

Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 8 (Blazor Wasm) - DISABLED
Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 8 (Blazor Server Wasm) - DISABLED
Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 9 (Blazor Wasm) - DISABLED
Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 9 (Blazor Server Wasm) - DISABLED

Tested scenarios with this PR and C# DevKit without the monovsdbg support:

With Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED
With Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - ENABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - ENABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) - DISABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) - DISABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) - DISABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) - DISABLED

package.json

package.nls.json

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts

gregg-miskelly · 2024-06-10T17:10:08Z

src/shared/utils.ts

@@ -43,6 +43,14 @@ export function isWebProject(projectPath: string): boolean {
    return projectFileText.toLowerCase().indexOf('sdk="microsoft.net.sdk.web"') >= 0;
 }

+export function isWebAssemblyProject(projectPath: string): boolean {
+    const projectFileText = fs.readFileSync(projectPath, 'utf8');


const projectFileText = fs.readFileSync(projectPath, 'utf8');

Instead of reading the file a second time, I would suggest changing isWebProject to getProjectFlags and returning both.

src/shared/assets.ts

…_ASSEMBLIES to enable hotreload.

…/vscode-csharp into dev/thays/support_wasm_monovsdbg

thaystg · 2024-06-28T05:44:04Z

@gregg-miskelly can you please review again?
I think I addressed all your comments.

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts

src/shared/assets.ts

src/shared/utils.ts

thaystg · 2024-07-08T19:55:08Z

@gregg-miskelly I think I'm done again. If you can review it will be great.

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts

gregg-miskelly

Otherwise LGTM

WardenGnaw · 2024-07-15T20:28:07Z

Did you want to update a case for the updatePackageDependencies script?

vscode-csharp/src/tools/updatePackageDependencies.ts

Line 276 in 602cd79

} else {

thaystg · 2024-07-16T13:49:34Z

Did you want to update a case for the updatePackageDependencies script?

vscode-csharp/src/tools/updatePackageDependencies.ts

Line 276 in 602cd79

} else {

I'm using npm run updatePackageDependencies to update the webassembly package but I didn't need to change this file.

JoeRobich · 2025-02-06T22:55:06Z

@thaystg Is this still a change we want to consider?

thaystg · 2025-02-07T13:39:14Z

Correct, we will work on it yet, but I will mark it as a draft for now.

thaystg · 2025-08-08T13:27:55Z

Can I get a review again here?

gregg-miskelly · 2025-08-08T16:53:50Z

package.json

@@ -707,6 +707,23 @@
      "binaries": [
        "./rzls"
      ]
+    },
+    {
+      "id": "VSWebAssemblyBridge",


id

Should this be added here so you can use the update dependencies script?

gregg-miskelly · 2025-08-08T17:46:04Z

src/shared/assets.ts

+            }
+        });
+        assetsPath = assetsPath.slice(0, -1);
+        return [assetsPath, this.executableProjects[0].outputPath];


this.executableProjects[0].outputPath

I am not quite following what this is doing -- we are returning the assetsPath of all the web assembly projects, but then the output path of whatever random project happens to be the first executable project in the solution.

gregg-miskelly · 2025-08-08T17:50:19Z

src/shared/assets.ts

+        return [assetsPath, this.executableProjects[0].outputPath];
+    }
+
+    public isDotNet9OrNewer(): boolean {


isDotNet9OrNewer

Shouldn't we combine this together with getAssetsPathAndProgram so we only return assets for wasm projects that target .NET 9?

gregg-miskelly · 2025-08-08T17:56:52Z

src/shared/utils.ts

@@ -35,12 +35,15 @@ export function findNetStandardTargetFramework(tfmShortNames: string[]): string
    return tfmShortNames.find((tf) => tf.startsWith('netstandard'));
 }

-export function isWebProject(projectPath: string): boolean {
-    const projectFileText = fs.readFileSync(projectPath, 'utf8');
+export function isWebProject(projectPath: string): [boolean, boolean] {


We now have two ways to detect a Blazor project. Should a project that is a Blazor project always have both? Or is one of them just going to return true for a subset of blazor projects?

Adding changes to support use monovsdbg to debug wasm apps.

1f4d94e

gregg-miskelly reviewed Jun 10, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

gregg-miskelly reviewed Jun 10, 2024

View reviewed changes

package.nls.json Outdated Show resolved Hide resolved

gregg-miskelly reviewed Jun 10, 2024

View reviewed changes

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts Outdated Show resolved Hide resolved

gregg-miskelly reviewed Jun 10, 2024

View reviewed changes

src/shared/assets.ts Show resolved Hide resolved

thaystg added 11 commits June 13, 2024 12:11

Adding VSWebAssemblyPackage.

d7f8606

Addressing Gregg's comments

cfb2d67

Fixing prettier

d59699b

Fixing package.json

981c74b

Merge branch 'main' into dev/thays/support_wasm_monovsdbg

0bc4ca2

Adding vswebassembly to gitignore

c4d88dc

Test if the vswebassembly path exists and also pass DOTNET_MODIFIABLE…

d3b8441

…_ASSEMBLIES to enable hotreload.

Fix prettier

b094acf

Bump VSWebAssemblyBridge.

4796772

Check targetFramework before enable it.

83de7bb

Merge branch 'dev/thays/support_wasm_monovsdbg' of github.com:thaystg…

e2802c1

…/vscode-csharp into dev/thays/support_wasm_monovsdbg

thaystg marked this pull request as ready for review June 22, 2024 00:38

thaystg requested review from a team as code owners June 22, 2024 00:38

thaystg requested a review from gregg-miskelly June 22, 2024 00:52

gregg-miskelly requested changes Jun 28, 2024

View reviewed changes

thaystg added 3 commits July 1, 2024 20:03

Addressing Gregg's comments.

d6fd0b6

Renaming function.

04b4c77

Addressing Gregg's comments.

a5452a8

thaystg requested a review from gregg-miskelly July 2, 2024 15:28

thaystg added 3 commits July 2, 2024 13:48

Merge branch 'main' into dev/thays/support_wasm_monovsdbg

2b1ee0d

Addressing Gregg's comments.

e06f914

Merge branch 'main' into dev/thays/support_wasm_monovsdbg

4e70917

gregg-miskelly reviewed Jul 8, 2024

View reviewed changes

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts Outdated Show resolved Hide resolved

gregg-miskelly reviewed Jul 8, 2024

View reviewed changes

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts Outdated Show resolved Hide resolved

gregg-miskelly approved these changes Jul 8, 2024

View reviewed changes

Addressing Gregg's suggestion.

9dfa93c

gregg-miskelly approved these changes Jul 11, 2024

View reviewed changes

thaystg marked this pull request as draft February 7, 2025 13:39

thaystg added 8 commits July 29, 2025 12:18

Merge branch 'main' into dev/thays/support_wasm_monovsdbg

c12e04b

fix vswebassembly version

b6a67c0

Merge branch 'main' into dev/thays/support_wasm_monovsdbg

7e49904

Fixing merge

4163249

fix compilation

4f86d19

Merge branch 'main' into dev/thays/support_wasm_monovsdbg

bcb7bdd

Last adjust to support wasm debugger with icordebug on vscode-csharp

d9176bd

fix eslint errors and adding .gitignore.

8fd232c

thaystg mentioned this pull request Aug 5, 2025

Debugging Blazor Webassembly running in a dev container dotnet/runtime#112860

Closed

Bump vswebassemblybridge

f4c236e

thaystg marked this pull request as ready for review August 8, 2025 13:27

gregg-miskelly reviewed Aug 8, 2025

View reviewed changes

Adding changes to support use monovsdbg to debug wasm apps. #7220

Are you sure you want to change the base?

Adding changes to support use monovsdbg to debug wasm apps. #7220

Uh oh!

Conversation

thaystg commented Jun 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregg-miskelly Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

thaystg Jun 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thaystg commented Jun 28, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thaystg commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregg-miskelly left a comment

Choose a reason for hiding this comment

Uh oh!

WardenGnaw commented Jul 15, 2024

Uh oh!

thaystg commented Jul 16, 2024

Uh oh!

JoeRobich commented Feb 6, 2025

Uh oh!

thaystg commented Feb 7, 2025

Uh oh!

thaystg commented Aug 8, 2025

Uh oh!

gregg-miskelly Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

gregg-miskelly Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

gregg-miskelly Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

gregg-miskelly Aug 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thaystg commented Jun 10, 2024 •

edited

Loading

thaystg commented Jul 8, 2024 •

edited

Loading