Catch unhandled exception when closing connection. (#5342)

imcarolwang · web-flow · commit f40747c13050 · 2023-11-02T15:46:06.000+08:00
diff --git a/src/System.ServiceModel.NetFramingBase/src/System/ServiceModel/Channels/ConnectionPool.cs b/src/System.ServiceModel.NetFramingBase/src/System/ServiceModel/Channels/ConnectionPool.cs
@@ -632,9 +632,13 @@ protected override void AbortItem(IConnection item)
             item.Abort();
         }
 
-        protected override ValueTask CloseItemAsync(IConnection item, TimeSpan timeout)
+        protected override async ValueTask CloseItemAsync(IConnection item, TimeSpan timeout)
         {
-            return item.CloseAsync(timeout);
+            try
+            {
+                await item.CloseAsync(timeout);
+            }
+            catch (Exception) { }
         }
 
         public virtual bool IsCompatible(IConnectionOrientedTransportChannelFactorySettings settings)

Original file line number	Diff line number	Diff line change
`@@ -632,9 +632,13 @@ protected override void AbortItem(IConnection item)`
`632`	`632`	`item.Abort();`
`633`	`633`	`}`
`634`	`634`
`635`		`- protected override ValueTask CloseItemAsync(IConnection item, TimeSpan timeout)`
	`635`	`+ protected override async ValueTask CloseItemAsync(IConnection item, TimeSpan timeout)`
`636`	`636`	`{`
`637`		`- return item.CloseAsync(timeout);`
	`637`	`+ try`
	`638`	`+ {`
	`639`	`+ await item.CloseAsync(timeout);`
	`640`	`+ }`
	`641`	`+ catch (Exception) { }`
`638`	`642`	`}`
`639`	`643`
`640`	`644`	`public virtual bool IsCompatible(IConnectionOrientedTransportChannelFactorySettings settings)`