Fix code analysis issues #12735
Merged
Fix code analysis issues #12735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12735 +/- ##
===================================================
+ Coverage 76.03780% 76.14751% +0.10970%
===================================================
Files 3181 3191 +10
Lines 639670 640105 +435
Branches 47215 47234 +19
===================================================
+ Hits 486391 487424 +1033
+ Misses 149759 149161 -598
Partials 3520 3520
Flags with carried forward coverage won't be shown. Click here to find out more. |
ViktorHofer
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the latest daily build of the .NET 10 SDK to build this repo causes various code analysis build errors for IDE0040, IDE0057, IDE0305, and IDE0306. Fixing those here. These were found as part of the work in dotnet/sdk#45749.
Microsoft Reviewers: Open in CodeFlow