Avoid serialization with in-process Clipboard use#13287
Merged
JeremyKuhne merged 2 commits intodotnet:mainfrom Apr 15, 2025
Merged
Avoid serialization with in-process Clipboard use#13287JeremyKuhne merged 2 commits intodotnet:mainfrom
JeremyKuhne merged 2 commits intodotnet:mainfrom
Conversation
When copy is not set to true, the original object is still available and we can get data directly without serializing through NRBF. - Updated `DataFormatNames` for case-insensitive format lookups. - Changed format equality checks in `DataStore` to be case-insensitive. - Renamed a test method in `ClipboardCoreTests` for clarity and added a new test for `SerializableObject` to ensure it does not use `BinaryFormatter`. - Introduced a generic `TryGetData<T>(out T data)` method in `Clipboard`. - Modified `SetDataObject` to use `WrappingDataObject` for improved data wrapping. - Enhanced `WrappingDataObject` to always consider `autoConvert` as true, aligning with native `IDataObject` behavior. - Updated assertions in `ClipboardTests` for more flexible type checking. - Added tests to verify the handling of serializable objects without using `BinaryFormatter`.
JeremyKuhne
added
area-Clipboard
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13287 +/- ##
===================================================
+ Coverage 62.09218% 62.19962% +0.10744%
===================================================
Files 1555 1556 +1
Lines 159260 159382 +122
Branches 14849 14857 +8
===================================================
+ Hits 98888 99135 +247
+ Misses 59648 59495 -153
- Partials 724 752 +28
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JeremyKuhne
added
the
📚 documentation
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, added some comments.
src/System.Private.Windows.Core/src/System/Private/Windows/Ole/DataFormatNames.cs
Show resolved
Hide resolved
...ore/tests/System.Private.Windows.Core.Tests/System/Private/Windows/Ole/ClipboardCoreTests.cs
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/ClipboardTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/OLE/WrappingDataObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/OLE/WrappingDataObject.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When copy is not set to true, the original object is still available and we can get data directly without serializing through NRBF.
DataFormatNamesfor case-insensitive format lookups.DataStoreto be case-insensitive.ClipboardCoreTestsfor clarity and added a new test forSerializableObjectto ensure it does not useBinaryFormatter.TryGetData<T>(out T data)method inClipboard.SetDataObjectto useWrappingDataObjectfor improved data wrapping.WrappingDataObjectto always considerautoConvertas true, aligning with nativeIDataObjectbehavior.ClipboardTestsfor more flexible type checking.BinaryFormatter.Microsoft Reviewers: Open in CodeFlow