Skip to content

Improve Message Box in WinForms #13440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+234 −6
Open

Improve Message Box in WinForms #13440

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f22357d
Add MessageBox API Suggestion
memoarfaa May 11, 2025
dc9b4a9
Complete MessageBox API Suggestion
memoarfaa May 11, 2025
eabcaee
Remove all MessageBox improvment and add only dark MessageBox style w…
memoarfaa May 12, 2025
81b583d
remove PublicAPI.Unshipped and fix build error
memoarfaa May 12, 2025
925fc08
remove PublicAPI.Unshipped and fix build error
memoarfaa May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...m.Windows.Forms.Analyzers/src/System/Windows/Forms/Analyzers/Diagnostics/DiagnosticIDs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ internal static class DiagnosticIDs
// Experimental, number group 5000+
public const string ExperimentalDarkMode = "WFO5001";
public const string ExperimentalAsync = "WFO5002";
public const string ExperimentalMessageBox = "WFO5003";
}
3 changes: 3 additions & 0 deletions src/System.Windows.Forms.Primitives/src/NativeMethods.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ CreateStdAccessibleObject
CreateWindowEx
CSIDL_*
CW_USEDEFAULT
CWPSTRUCT
DATETIMEPICK_CLASS
DeactivateActCtx
DefFrameProc
Expand Down Expand Up @@ -149,6 +150,7 @@ GetCurrentThread
GetCursor
GetCursorPos
GetDIBits
GetDlgCtrlID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GetDlgCtrlID

This can be removed as it looks like it is not used.

GetDlgItem
GetDlgItemInt
GetDoubleClickTime
Expand Down Expand Up @@ -223,6 +225,7 @@ GetViewportExtEx
GetWindow
GetWindowDpiAwarenessContext
GetWindowPlacement
GetWindowTheme
GetWorldTransform
GMR_*
HC_*
Expand Down
20 changes: 20 additions & 0 deletions src/System.Windows.Forms/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
static System.Windows.Forms.MessageBox.BackColor.get -> System.Drawing.Color
static System.Windows.Forms.MessageBox.BackColor.set -> void
static System.Windows.Forms.MessageBox.FooterBackColor.get -> System.Drawing.Color
static System.Windows.Forms.MessageBox.FooterBackColor.set -> void
static System.Windows.Forms.MessageBox.ForeColor.get -> System.Drawing.Color
static System.Windows.Forms.MessageBox.ForeColor.set -> void
static System.Windows.Forms.MessageBox.ResourceType.get -> System.Type?
static System.Windows.Forms.MessageBox.ResourceType.set -> void
[WFO5003]static System.Windows.Forms.MessageBox.Show(string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton, System.Windows.Forms.MessageBoxOptions options) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton, System.Windows.Forms.MessageBoxOptions options, bool displayHelpButton) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton, System.Windows.Forms.MessageBoxOptions options, string! helpFilePath) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton, System.Windows.Forms.MessageBoxOptions options, string! helpFilePath, string! keyword) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton, System.Windows.Forms.MessageBoxOptions options, string! helpFilePath, System.Windows.Forms.HelpNavigator navigator) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton, System.Windows.Forms.MessageBoxOptions options, string! helpFilePath, System.Windows.Forms.HelpNavigator navigator, object? param) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(System.Windows.Forms.IWin32Window? owner, string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton, System.Windows.Forms.MessageBoxOptions options, string! helpFilePath) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(System.Windows.Forms.IWin32Window? owner, string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton, System.Windows.Forms.MessageBoxOptions options, string! helpFilePath, string! keyword) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(System.Windows.Forms.IWin32Window? owner, string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton, System.Windows.Forms.MessageBoxOptions options, string! helpFilePath, System.Windows.Forms.HelpNavigator navigator) -> System.Windows.Forms.DialogResult
[WFO5003]static System.Windows.Forms.MessageBox.Show(System.Windows.Forms.IWin32Window? owner, string? text, string? caption, System.Windows.Forms.MessageBoxButtons buttons, System.Drawing.Icon! icon, System.Windows.Forms.MessageBoxDefaultButton defaultButton, System.Windows.Forms.MessageBoxOptions options, string! helpFilePath, System.Windows.Forms.HelpNavigator navigator, object? param) -> System.Windows.Forms.DialogResult
Loading