Skip to content

Add InternalRaiseAutomationNotification in WmDateChanged of the MonthCalendar #13707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add InternalRaiseAutomationNotification in WmDateChanged of the MonthCalendar #13707

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
804c36e
Add InternalRaiseAutomationNotification in WmDateChanged of the Month…
LeafShi1 Jul 16, 2025
553996e
Add switch EnableMonthCalendarAutomationNotification
LeafShi1 Jul 17, 2025
dbac5c4
Update src/System.Windows.Forms.Primitives/src/System/LocalAppContext…
LeafShi1 Jul 21, 2025
6211a11
Focus the MonthCanlendar when select date changed
Jul 22, 2025
728b2c6
Removing extra changes
Jul 22, 2025
acb2d59
Add NotifyWinEvent in MonthCalendar
LeafShi1 Jul 23, 2025
c1aa344
Add MSAA focus event in OnGotFocus
LeafShi1 Aug 7, 2025
3d5ae61
Add handle check before invoke PInvoke.NotifyWinEvent
LeafShi1 Sep 24, 2025
fb866e2
Allow critical exceptions (e.g., OutOfMemoryException) to propagate
Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions src/System.Windows.Forms/System/Windows/Forms/Controls/MonthCalendar/MonthCalendar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1428,6 +1428,8 @@ protected override void OnGotFocus(EventArgs e)
{
base.OnGotFocus(e);

NotifyWinEvent(AccessibleEvents.Focus);

if (IsAccessibilityObjectCreated)
{
((MonthCalendarAccessibleObject)AccessibilityObject).FocusedCell?.RaiseAutomationEvent(UIA_EVENT_ID.UIA_AutomationFocusChangedEventId);
Expand Down Expand Up @@ -2063,8 +2065,9 @@ private unsafe void WmDateChanged(ref Message m)
_selectionStart = start;
_selectionEnd = end;

AccessibilityNotifyClients(AccessibleEvents.NameChange, -1);
AccessibilityNotifyClients(AccessibleEvents.ValueChange, -1);
NotifyWinEvent(AccessibleEvents.Focus);
NotifyWinEvent(AccessibleEvents.NameChange);
NotifyWinEvent(AccessibleEvents.ValueChange);

// We should use the Date for comparison in this case. The user can work in the calendar only with dates,
// while the minimum / maximum date can contain the date and custom time, which, when comparing Ticks,
Expand Down Expand Up @@ -2094,6 +2097,25 @@ private unsafe void WmDateChanged(ref Message m)
OnDateChanged(new DateRangeEventArgs(start, end));
}

private void NotifyWinEvent(AccessibleEvents accessibleEvent)
{
try
{
if (IsHandleCreated)
{
PInvoke.NotifyWinEvent(
(uint)accessibleEvent,
this,
(int)OBJECT_IDENTIFIER.OBJID_CLIENT,
(int)PInvoke.CHILDID_SELF);
}
}
catch (Exception ex) when (!ex.IsCriticalException())
{
Debug.Fail($"NotifyWinEvent failed: {ex.Message}");
}
}

/// <summary>
/// Handles the MCN_GETDAYSTATE notification by returning an array of bitmasks, one entry per month,
/// that specifies which dates to display in bold.
Expand Down