Add code coverage for ToolStripManagerModalMenuFilterHostedWindowsFor… #13762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zheng-Li01
added
the
waiting-review
LeafShi1
previously approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for the ToolStripManagerModalMenuFilterHostedWindowsFormsMessageHook class to improve code coverage. The tests verify basic functionality of constructor, message hook installation, and uninstallation methods.
Key changes:
- Added comprehensive unit test coverage for a previously untested internal class
- Tests verify proper state management for message hook installation/uninstallation
- Uses reflection and TestAccessor to test internal implementation details
...ms/System/Windows/Forms/ToolStripManagerModalMenuFilterHostedWindowsFormsMessageHookTests.cs
Show resolved
Hide resolved
...ms/System/Windows/Forms/ToolStripManagerModalMenuFilterHostedWindowsFormsMessageHookTests.cs
Show resolved
Hide resolved
...ms/System/Windows/Forms/ToolStripManagerModalMenuFilterHostedWindowsFormsMessageHookTests.cs
Show resolved
Hide resolved
Open
48 tasks
ricardobossan
requested changes
Aug 7, 2025
...ms/System/Windows/Forms/ToolStripManagerModalMenuFilterHostedWindowsFormsMessageHookTests.cs
Outdated
Show resolved
Hide resolved
...ms/System/Windows/Forms/ToolStripManagerModalMenuFilterHostedWindowsFormsMessageHookTests.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #13442
Proposed changes
Add unit test file:ToolStripManagerModalMenuFilterHostedWindowsFormsMessageHookTests.cs for public/protected methods/properties of the ToolStripManagerModalMenuFilterHostedWindowsFormsMessageHook.cs
Microsoft Reviewers: Open in CodeFlow