Skip to content

Add hover visual effect for Popup button #13891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add hover visual effect for Popup button #13891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c67a19b
Add hover visual effect for Popup button
Sep 23, 2025
c6a34f4
When pressed, highlight all borders
Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ...tem/Windows/Forms/Controls/Buttons/ButtonInternal/DarkMode/PopupButtonDarkModeRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,10 @@ private static void DrawButtonBorder(Graphics graphics, Rectangle bounds, PushBu

if (state == PushButtonState.Pressed)
{
// In pressed state, invert the 3D effect: highlight bottom/right, shadow top/left
topLeftOuter = DefaultColors.ShadowColor; // shadow
bottomRightOuter = DefaultColors.HighlightColor; // highlight
topLeftInner = DefaultColors.ShadowDarkColor; // deeper shadow
// In pressed state, brighter all borders to simulate the button being pressed.
topLeftOuter = DefaultColors.HighlightBrightColor; // brighter highlight
bottomRightOuter = DefaultColors.HighlightBrightColor; // brighter highlight
topLeftInner = DefaultColors.HighlightBrightColor; // deeper shadow
bottomRightInner = DefaultColors.HighlightBrightColor; // brighter highlight
}
else if (state == PushButtonState.Disabled)
Expand All @@ -155,9 +155,17 @@ private static void DrawButtonBorder(Graphics graphics, Rectangle bounds, PushBu
topLeftInner = DefaultColors.DisabledBorderMidColor;
bottomRightInner = DefaultColors.DisabledBorderMidColor;
}
else if (state == PushButtonState.Hot)
{
// In hover state, invert the 3D effect: highlight bottom/right, shadow top/left
topLeftOuter = DefaultColors.ShadowColor; // shadow
bottomRightOuter = DefaultColors.HighlightColor; // highlight
topLeftInner = DefaultColors.ShadowColor; // shadow
bottomRightInner = DefaultColors.HighlightColor; // highlight
}
else
{
// Normal/hot: highlight top/left, shadow bottom/right
// Normal: highlight top/left, shadow bottom/right
topLeftOuter = DefaultColors.HighlightColor; // highlight
bottomRightOuter = DefaultColors.ShadowColor; // shadow
topLeftInner = DefaultColors.HighlightBrightColor; // brighter highlight
Expand Down