Fix ToolStripStatusLabel text visibility in High Contrast mode with System RenderMode #14100
+188
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13640
Proposed changes
RendererOverridedelegation toOnRenderToolStripStatusLabelBackgroundinToolStripSystemRendererRendererOverridedelegation toOnRenderLabelBackgroundinToolStripSystemRendererOnRenderToolStripStatusLabelBackgroundoverride inToolStripHighContrastRendererto fill background with highlight color when selectedCustomer Impact
IsLink=trueare now visible in High Contrast mode when using System RenderModeRegression?
Risk
OnRenderButtonBackgroundand other rendering methods.Test methodology
ToolStripStatusLabelTests.Rendering.cswith High Contrast rendering testsToolStripLabelTests.Rendering.cswith High Contrast rendering testsSystemColors.HighlightbackgroundAccessibility testing
This PR fixes an accessibility bug. The root cause was that
OnRenderToolStripStatusLabelBackgroundandOnRenderLabelBackgrounddid not delegate toRendererOverride, preventingToolStripHighContrastRendererfrom filling the background with highlight color for selected items.Test environment(s)
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
0t3vsblobprodcus362.vsblob.vsassets.io/home/REDACTED/work/winforms/winforms/.dotnet/dotnet /home/REDACTED/work/winforms/winforms/.dotnet/dotnet restore(dns block)imzvsblobprodcus368.vsblob.vsassets.io/home/REDACTED/work/winforms/winforms/.dotnet/dotnet /home/REDACTED/work/winforms/winforms/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/winforms/winforms/artifacts/toolset/restore.proj /bl:/home/REDACTED/work/winforms/winforms/artifacts/log/Debug/ToolsetRestore.binlog /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/winforms/winforms/artifacts/toolset/11.0.0-beta.25601.107.txt(dns block)/home/REDACTED/work/winforms/winforms/.dotnet/dotnet /home/REDACTED/work/winforms/winforms/.dotnet/dotnet restore(dns block)/home/REDACTED/work/winforms/winforms/.dotnet/dotnet /home/REDACTED/work/winforms/winforms/.dotnet/dotnet build src/System.Windows.Forms/System.Windows.Forms.csproj --no-restore(dns block)l49vsblobprodcus358.vsblob.vsassets.io/home/REDACTED/work/winforms/winforms/.dotnet/dotnet /home/REDACTED/work/winforms/winforms/.dotnet/dotnet restore(dns block)rcxvsblobprodcus328.vsblob.vsassets.io/home/REDACTED/work/winforms/winforms/.dotnet/dotnet /home/REDACTED/work/winforms/winforms/.dotnet/dotnet build src/System.Windows.Forms/System.Windows.Forms.csproj --no-restore(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Microsoft Reviewers: Open in CodeFlow