Skip to content

Commit 8efcd1c

Browse files
authored
Merge pull request #9717 from dotnet/backport/pr-9681-to-release/9.0
[release/9.0] Work around d3d redist incompat.
2 parents 58ad3e3 + 03ed695 commit 8efcd1c

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

global.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
},
2121
"native-tools": {
2222
"strawberry-perl": "5.38.0.1",
23-
"net-framework-48-ref-assemblies": "0.0.0.1"
23+
"net-framework-48-ref-assemblies": "0.0.0.1",
24+
"windows-sdk-d3d-redist": "1.0.0"
2425
}
2526
}

src/Microsoft.DotNet.Wpf/redist/D3DCompiler/D3DCompiler.vcxproj

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,18 @@
2525
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
2626
<Import Project="$(WpfCppProps)" />
2727
<PropertyGroup>
28-
<!--
29-
Target assembly will be a privatized copy of D3DCompiler, like
28+
<!--
29+
Target assembly will be a privatized copy of D3DCompiler, like
3030
d3dcompiler_47_cor3.dll
3131
-->
3232
<TargetName>$(D3DCompilerDllBaseName)$(D3DCompilerVersion)$(WpfVersionSuffix)</TargetName>
3333
</PropertyGroup>
3434
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
3535
<PropertyGroup>
36-
<!-- ARM64 will use the windows\system32 version -->
37-
<RedistSourcePath>$(Windows10SdkPath)Redist\D3D\$(Architecture)\$(D3DCompilerDllBaseName)$(D3DCompilerVersion).dll</RedistSourcePath>
36+
<!-- ARM64 will use the windows\system32 version -->
37+
<!-- ISSUE!! https://github.com/dotnet/wpf/issues/9670: An updated D3D Redist is incompatible with Win10, at least when built with the 19041 Windows SDK. This is
38+
a temporary workaround for this issue. We pull from netcore native assets instead. -->
39+
<RedistSourcePath>$(RepositoryToolsDir)native\bin\windows-sdk-d3d-redist\1.0.0\D3D\$(Architecture)\$(D3DCompilerDllBaseName)$(D3DCompilerVersion).dll</RedistSourcePath>
3840
</PropertyGroup>
3941
<PropertyGroup Label="Globals">
4042
<VCProjectVersion>16.0</VCProjectVersion>

0 commit comments

Comments
 (0)