Use source-generated regex instead of runtime compilation (SYSLIB1045) (#10303)

* Fix immediate SYSLIB1045 warning

* Replace inline regex with GeneratedRegex

Author: h3xds1nz

src/Microsoft.DotNet.Wpf/src/.editorconfig

@@ -224,9 +224,6 @@ dotnet_diagnostic.IDE0300.severity = suggestion
 # IDE1006: Naming Styles
 dotnet_diagnostic.IDE1006.severity = suggestion
 
-# SYSLIB1045: Convert to 'GeneratedRegexAttribute'.
-dotnet_diagnostic.SYSLIB1045.severity = suggestion
-
 # ---------------------
 # Ref specific C# files
 # ---------------------

src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/UidManager.cs

@@ -925,7 +925,7 @@ private string GeneratePrefix()
 
 
     // writing to a file, removing or updating uid
-    internal sealed class UidWriter
+    internal sealed partial class UidWriter
     {
         internal UidWriter(UidCollector collector, Stream source, Stream target)
         {
@@ -1101,7 +1101,7 @@ private void WriteNewUid(Uid uid)
             // escape all the Xml entities in the value
             string attributeValue = EscapedXmlEntities.Replace(
                 uid.Value,
-                EscapeMatchEvaluator
+                s_escapeMatchEvaluator
                 );
 
             string clause = string.Format(
@@ -1128,11 +1128,6 @@ private void WriteNewNamespace()
 
         private void WriteNewAttributeValue(string value)
         {
-            string attributeValue = EscapedXmlEntities.Replace(
-                value,
-                EscapeMatchEvaluator
-                );
-
             _targetWriter.Write(
                 string.Format(
                     TypeConverterHelper.InvariantEnglishUS,
@@ -1308,8 +1303,13 @@ private enum WriterAction
             Skip  = 1,  // skip the content
         }
 
-        private static Regex          EscapedXmlEntities   = new Regex("(<|>|\"|'|&)", RegexOptions.CultureInvariant | RegexOptions.Compiled);
-        private static MatchEvaluator EscapeMatchEvaluator = new MatchEvaluator(EscapeMatch);
+#if !NETFX
+        [GeneratedRegex("(<|>|\"|'|&)", RegexOptions.CultureInvariant)]
+        private static partial Regex EscapedXmlEntities { get; }
+#else
+        private static readonly Regex EscapedXmlEntities = new("(<|>|\"|'|&)", RegexOptions.CultureInvariant | RegexOptions.Compiled);
+#endif
+        private static readonly MatchEvaluator s_escapeMatchEvaluator = new MatchEvaluator(EscapeMatch);
 
         /// <summary>
         /// the delegate to escape the matched pattern

src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Documents/WinRTSpellerInterop.cs

@@ -543,6 +543,9 @@ private void ClearDictionaries(bool disposing = false)
             }
         }
 
+        [GeneratedRegex(@"\s*\#LID\s+(\d+)\s*", RegexOptions.Singleline | RegexOptions.CultureInvariant)]
+        private static partial Regex LexiconCultureRegex { get; }
+
         /// <summary>
         ///     Detect whether the <paramref name="line"/> is of the form #LID nnnn,
         ///     and if it is, try to instantiate a CultureInfo object with LCID nnnn.
@@ -553,17 +556,14 @@ private void ClearDictionaries(bool disposing = false)
         /// </returns>
         private static CultureInfo TryParseLexiconCulture(string line)
         {
-            const string regexPattern = @"\s*\#LID\s+(\d+)\s*";
-            RegexOptions regexOptions = RegexOptions.Singleline | RegexOptions.CultureInvariant | RegexOptions.Compiled;
-
             CultureInfo result = CultureInfo.InvariantCulture;
 
             if (line == null)
             {
                 return result;
             }
 
-            string[] matches = Regex.Split(line.Trim(), regexPattern, regexOptions);
+            string[] matches = LexiconCultureRegex.Split(line.Trim());
 
             // We expect 1 exact match, which implies matches.Length == 3 (before, match, after)
             if (matches.Length != 3)