-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(Table): Table add button to add disabled callback #4607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR adds a new callback functionality to control the disabled state of the Add button in the Table component. The implementation follows the same pattern as existing edit and delete button callbacks, introducing a new DisableAddButtonCallback parameter and integrating it with the table's toolbar rendering logic. Sequence diagram for Add button disable callbacksequenceDiagram
participant User
participant Table
participant Button
User->>Table: Interact with Table
Table->>Button: Render Add Button
Button->>Table: Check IsDisabled via GetAddButtonStatus()
Table->>Table: Invoke DisableAddButtonCallback
Table-->>Button: Return IsDisabled state
Button-->>User: Display Add Button with updated state
Class diagram for updated Table componentclassDiagram
class Table {
+Func<List<TItem>, bool> DisableAddButtonCallback
+Func<List<TItem>, bool> DisableDeleteButtonCallback
+Func<List<TItem>, bool> DisableEditButtonCallback
+bool GetAddButtonStatus()
}
note for Table "New DisableAddButtonCallback parameter added to control Add button state"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4607 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27373 27375 +2
Branches 3915 3916 +1
=========================================
+ Hits 27373 27375 +2 ☔ View full report in Codecov by Sentry. |
Table add button to add disabled callback
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4604
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a callback function to the Table component to allow disabling the 'Add' button based on custom logic, and include a unit test to ensure its correct functionality.
New Features:
Tests: