feat(Layout): add default style #4609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis PR implements default styling for the layout components by updating SCSS variables and adding new style definitions. The changes primarily focus on customizing the color scheme and visual appearance of the header, sidebar, and menu elements with predefined values instead of using CSS variable references. Class diagram for updated SCSS variables in layout componentsclassDiagram
class Layout {
--bb-layout-header-height
--bb-layout-header-background
--bb-layout-header-color
--bb-layout-headerbar-color
--bb-layout-headerbar-background
--bb-layout-headerbar-border-color
--bb-layout-headerbar-padding
--bb-layout-title-margin-left
--bb-layout-banner-font-size
--bb-layout-banner-logo-width
--bb-layout-menu-user-banner-background
--bb-layout-menu-user-border-color
--bb-layout-menu-item-hover-bg
}
class DropdownLogout {
--bb-logout-text-color
--bb-logout-user-bg
--bb-logout-menu-border-color
}
class LayoutMenu {
--bb-menu-item-hover-bg
}
Layout --> DropdownLogout : uses
Layout --> LayoutMenu : uses
note for Layout "Updated SCSS variables for layout components"
Class diagram for updated theme variables in bootstrapblazor.scssclassDiagram
class Theme {
$bb-layout-header-height
$bb-layout-header-background
$bb-layout-header-color
$bb-layout-headerbar-background
$bb-layout-headerbar-border-color
$bb-layout-headerbar-padding
$bb-layout-footer-color
$bb-layout-footer-height
$bb-layout-sidebar-width
$bb-layout-sidebar-collapse-width
$bb-layout-sidebar-banner-background
$bb-layout-sidebar-background
$bb-layout-sidebar-color
$bb-layout-title-color
$bb-layout-title-margin-left
$bb-layout-banner-font-size
$bb-layout-banner-logo-width
$bb-layout-menu-user-banner-background
$bb-layout-menu-user-border-color
$bb-layout-menu-item-hover-bg
}
note for Theme "Updated theme variables for layout styling"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider keeping CSS variable references (like
var(--bs-body-bg)) and setting default values for them instead of using hardcoded colors. This maintains theme customization flexibility while still providing default styles.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj
Member
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider keeping theme flexibility by using CSS variables instead of hardcoded color values to make it easier for users to customize the appearance
- Please update the documentation to describe the new default style and how users can override these values
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4609 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27375 27375
Branches 3916 3916
=========================================
Hits 27375 27375 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add default style
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #4608
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: