Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Nov 14, 2024

update test for nullable value

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4655

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update unit tests to handle nullable values by changing EventCallback types to accept nullable types, ensuring tests are compatible with nullable value scenarios.

Bug Fixes:

  • Update test cases to handle nullable values correctly by changing EventCallback types to accept nullable types.

Tests:

  • Modify unit tests across multiple components to support nullable value changes, ensuring compatibility with nullable types.

@bb-auto bb-auto bot added the test This is unit test label Nov 14, 2024
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 14, 2024

Reviewer's Guide by Sourcery

This PR updates test files to properly handle nullable string values in event callbacks and parameter types. The changes primarily involve modifying EventCallback.Factory.Create calls to use nullable type parameters (string? and SelectedItem?) to match the actual usage in the components.

Updated class diagram for EventCallback usage with nullable types

classDiagram
    class ValidateFormTest {
        +Validate_Ok()
        +OnFieldValueChanged_Ok()
        +ValidateAllProperties_Ok()
        +ShowRequiredMark_Ok()
        +ShowLabel_Ok()
    }
    class SelectTest {
        +SelectItem_Ok()
        +IsVirtualize_BindValue()
        +IsVirtualize_DefaultVirtualizeItemText()
    }
    class TransferTest {
        +Items_Ok()
        +ValidateForm_Ok()
        +MaxMin_Ok()
    }
    class DateTimeRangeTest {
        +ValueChanged_Ok()
    }
    class InputTest {
        +OnInput_Ok()
        +OnValueChanged_Ok()
    }
    class SelectTreeTest {
        +Value_Null()
        +Valid_Ok()
    }
    class InputNumberTest {
        +SetParametersAsync()
        +InternalFormat(string? value)
    }
    note for ValidateFormTest "Updated to use nullable string in EventCallback"
    note for SelectTest "Updated to use nullable SelectedItem in EventCallback"
    note for TransferTest "Updated to use nullable string in EventCallback"
    note for DateTimeRangeTest "Updated to use nullable DateTimeRangeValue in EventCallback"
    note for InputTest "Updated to use nullable string in EventCallback"
    note for SelectTreeTest "Updated to use nullable string in EventCallback"
    note for InputNumberTest "Updated InternalFormat to accept nullable string"
Loading

File-Level Changes

Change Details Files
Updated EventCallback signatures to support nullable types
  • Modified EventCallback.Factory.Create to use string? instead of string
  • Modified EventCallback.Factory.Create to use SelectedItem? instead of SelectedItem
  • Updated value parameters to be nullable where appropriate
test/UnitTest/Components/ValidateFormTest.cs
test/UnitTest/Components/SelectTest.cs
test/UnitTest/Components/TransferTest.cs
test/UnitTest/Components/DateTimeRangeTest.cs
test/UnitTest/Components/InputTest.cs
test/UnitTest/Components/SelectTreeTest.cs
Updated method signature to handle nullable parameter
  • Modified InternalFormat method parameter from string to string?
test/UnitTest/Components/InputNumberTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4655 Update tests to handle nullable values in various components

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 14, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4b33dae) to head (e7f57b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4656   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27419     27419           
  Branches      3928      3928           
=========================================
  Hits         27419     27419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit a8fa755 into main Nov 14, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the test-nullable branch November 14, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test This is unit test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(Display): update test for nullable value

2 participants