-
-
Notifications
You must be signed in to change notification settings - Fork 365
test(Display): update test for nullable value #4656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR updates test files to properly handle nullable string values in event callbacks and parameter types. The changes primarily involve modifying EventCallback.Factory.Create calls to use nullable type parameters (string? and SelectedItem?) to match the actual usage in the components. Updated class diagram for EventCallback usage with nullable typesclassDiagram
class ValidateFormTest {
+Validate_Ok()
+OnFieldValueChanged_Ok()
+ValidateAllProperties_Ok()
+ShowRequiredMark_Ok()
+ShowLabel_Ok()
}
class SelectTest {
+SelectItem_Ok()
+IsVirtualize_BindValue()
+IsVirtualize_DefaultVirtualizeItemText()
}
class TransferTest {
+Items_Ok()
+ValidateForm_Ok()
+MaxMin_Ok()
}
class DateTimeRangeTest {
+ValueChanged_Ok()
}
class InputTest {
+OnInput_Ok()
+OnValueChanged_Ok()
}
class SelectTreeTest {
+Value_Null()
+Valid_Ok()
}
class InputNumberTest {
+SetParametersAsync()
+InternalFormat(string? value)
}
note for ValidateFormTest "Updated to use nullable string in EventCallback"
note for SelectTest "Updated to use nullable SelectedItem in EventCallback"
note for TransferTest "Updated to use nullable string in EventCallback"
note for DateTimeRangeTest "Updated to use nullable DateTimeRangeValue in EventCallback"
note for InputTest "Updated to use nullable string in EventCallback"
note for SelectTreeTest "Updated to use nullable string in EventCallback"
note for InputNumberTest "Updated InternalFormat to accept nullable string"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4656 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27419 27419
Branches 3928 3928
=========================================
Hits 27419 27419 ☔ View full report in Codecov by Sentry. |
update test for nullable value
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4655
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update unit tests to handle nullable values by changing EventCallback types to accept nullable types, ensuring tests are compatible with nullable value scenarios.
Bug Fixes:
Tests: