-
-
Notifications
You must be signed in to change notification settings - Fork 365
doc(net9): remove 404 redirect middle ware #4660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR removes the 404 redirect middleware that was previously redirecting all 404 errors to the home page, and updates the Chart.js import path to use the UMD version of the library. Sequence diagram for 404 redirect middleware removalsequenceDiagram
participant User
participant Server
User->>Server: Request non-existent page
Server-->>User: 404 Not Found
note right of Server: Previously redirected to home page
note right of Server: Now returns 404 status
Class diagram for updated Chart.js importclassDiagram
class LineRazor {
- chart.js
+ chart.umd.js
+ Data
+ init(id, chartData)
}
note for LineRazor "Updated import path for Chart.js to use UMD version"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please document what users will now see when they encounter a 404 error, since this removes the redirect to homepage behavior.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4660 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27419 27419
Branches 3928 3928
=========================================
Hits 27419 27419 ☔ View full report in Codecov by Sentry. |
remove 404 redirect middle ware
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4659
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the 404 redirect middleware and update the Chart.js module import path to the UMD version.
Bug Fixes:
Enhancements: