Skip to content

fix(Checkbox): not trigger OnStateChanged callback when set TValue to bool #4667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

fix(Checkbox): not trigger OnStateChanged callback when set TValue to bool #4667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01c4384
refactor: 修复布尔值时不触发 OnStateChanged 回调问题
ArgoZhang Nov 15, 2024
05dc08a
test: 增加单元测试
ArgoZhang Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/BootstrapBlazor/Components/Checkbox/Checkbox.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,21 +215,23 @@ private async Task<bool> InternalStateChanged(CheckboxState state)
if (IsBoolean)
{
CurrentValue = (TValue)(object)(state == CheckboxState.Checked);
}

if (State != state)
{
State = state;
if (StateChanged.HasDelegate)
if (ValueChanged.HasDelegate)
{
await StateChanged.InvokeAsync(State);
ret = false;
}
}

if (OnStateChanged != null)
{
await OnStateChanged(State, Value);
}
State = state;
if (StateChanged.HasDelegate)
{
await StateChanged.InvokeAsync(State);
ret = false;
}

if (OnStateChanged != null)
{
await OnStateChanged(State, Value);
}
return ret;
}
Expand Down
21 changes: 21 additions & 0 deletions test/UnitTest/Components/CheckboxListTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,27 @@ public async Task Checkbox_OnTriggerClickAsync()
Assert.Equal(CheckboxState.Checked, cut.Instance.State);
}

[Fact]
public async Task Bool_TriggerStateChanged_Ok()
{
bool value = false;
// 测试 bool 值改变值时触发 StateChanged 回调方法
var cut = Context.RenderComponent<Checkbox<bool>>(pb =>
{
pb.Add(a => a.Value, false);
pb.Add(a => a.OnStateChanged, (state, v) =>
{
value = v;
return Task.CompletedTask;
});
});

// JavaScript 调用 OnTriggerClickAsync 方法
await cut.InvokeAsync(() => cut.Instance.OnTriggerClickAsync());
Assert.Equal(CheckboxState.Checked, cut.Instance.State);
Assert.True(value);
}

[Fact]
public void Checkbox_Dispose()
{
Expand Down