Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Nov 16, 2024

remove visual studio 2019

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4669

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Documentation:

  • Update documentation to remove references to Visual Studio 2019, replacing them with a general reference to Visual Studio.

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Nov 16, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 16, 2024
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 16, 2024

Reviewer's Guide by Sourcery

This PR updates documentation to remove specific references to Visual Studio 2019, replacing them with more general references to Visual Studio. It also updates the supported .NET version list to include NET9.

Class diagram for InstallContent.razor changes

classDiagram
    class InstallContent {
        +String P1
        +String P2
        +String P3
        +String P4
        +String P5
    }
    note for InstallContent "Updated to remove specific reference to Visual Studio 2019 and include NET9 in supported versions."
Loading

Class diagram for LayoutPages.razor changes

classDiagram
    class LayoutPages {
        +String H1
        +String P1
        +String P2
        +String P3
        +String P4
        +String P5
        +String P6
        +String P7
        +String P8
        +String P9
        +String P10
        +String P11
        +String P12
        +String P13
        +String P14
        +String P15
    }
    note for LayoutPages "Updated to remove specific reference to Visual Studio 2019."
Loading

Class diagram for readme.md changes

classDiagram
    class Readme {
        +String InstallationGuide
    }
    note for Readme "Updated to remove specific reference to Visual Studio 2019."
Loading

File-Level Changes

Change Details Files
Update Visual Studio references in documentation
  • Replace 'Visual Studio 2019' with generic 'Visual Studio' references
  • Update Visual Studio installation guide link text
src/BootstrapBlazor.Server/Components/Components/InstallContent.razor
src/BootstrapBlazor.Server/Components/Samples/LayoutPages.razor
src/BootstrapBlazor/readme.md
Update supported .NET versions
  • Add NET9 to the list of supported .NET versions
src/BootstrapBlazor.Server/Components/Components/InstallContent.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#4669 Remove references to Visual Studio 2019 from documentation

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang enabled auto-merge (squash) November 16, 2024 01:29
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Nov 16, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc1a76c) to head (fc7dfe9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4670   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27428     27428           
  Branches      3929      3929           
=========================================
  Hits         27428     27428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang
Copy link
Member Author

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please split out the addition of NET9 to supported frameworks into a separate PR. This PR should focus only on the Visual Studio documentation updates.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 624ade0 into main Nov 16, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the doc-readme branch November 16, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(Install): remove visual studio 2019

2 participants