-
-
Notifications
You must be signed in to change notification settings - Fork 365
doc(Install): remove visual studio 2019 #4670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR updates documentation to remove specific references to Visual Studio 2019, replacing them with more general references to Visual Studio. It also updates the supported .NET version list to include NET9. Class diagram for InstallContent.razor changesclassDiagram
class InstallContent {
+String P1
+String P2
+String P3
+String P4
+String P5
}
note for InstallContent "Updated to remove specific reference to Visual Studio 2019 and include NET9 in supported versions."
Class diagram for LayoutPages.razor changesclassDiagram
class LayoutPages {
+String H1
+String P1
+String P2
+String P3
+String P4
+String P5
+String P6
+String P7
+String P8
+String P9
+String P10
+String P11
+String P12
+String P13
+String P14
+String P15
}
note for LayoutPages "Updated to remove specific reference to Visual Studio 2019."
Class diagram for readme.md changesclassDiagram
class Readme {
+String InstallationGuide
}
note for Readme "Updated to remove specific reference to Visual Studio 2019."
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4670 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27428 27428
Branches 3929 3929
=========================================
Hits 27428 27428 ☔ View full report in Codecov by Sentry. |
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please split out the addition of NET9 to supported frameworks into a separate PR. This PR should focus only on the Visual Studio documentation updates.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
remove visual studio 2019
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4669
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Documentation: