-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(Calendar): add HeaderTemplate parameter #4674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Calendar): add HeaderTemplate parameter #4674
Conversation
Reviewer's Guide by SourceryThis PR adds support for additional header columns in the Calendar component's week view. The implementation adds a new AdditionalHeaders parameter that accepts an array of strings, which are rendered as extra columns before the weekday headers. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @densen2014. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @densen2014 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide documentation for the new AdditionalHeaders parameter and include a demo showing its usage.
- The PR checklist is incomplete - please review and check all relevant items, particularly regarding documentation and demo requirements.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4674 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 633 634 +1
Lines 28136 28159 +23
Branches 4036 4039 +3
=========================================
+ Hits 28136 28159 +23 ☔ View full report in Codecov by Sentry. |
|
@densen2014 it should be a good feature to have, can you solve the conflicts and re-pull-request again? |
add AdditionalHeaders parameter
Summary of the changes (Less than 80 chars)
周视图添加附加列
Description
fixes #5102
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: