Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Nov 22, 2024

update package for style

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4718

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Update CSS variables for global search styles to improve UI consistency.

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Nov 22, 2024
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 22, 2024

Reviewer's Guide by Sourcery

The changes reorganize CSS variables related to the search dialog styling by moving them from a deep selector in Header.razor.css to a more appropriate location in site.css under the .search-dialog-mask selector. This improves the organization and maintainability of the search-related styles.

Class diagram for CSS variable reorganization

classDiagram
    class SiteCSS {
        --bb-main-pading: 1rem
        --bb-sidebar-body-hover-bg: rgba(175, 184, 193, 0.2)
        --bb-sidebar-body-drag-hover-bg: rgb(9, 105, 218)
        --bb-code-bg: #e9ecef
        --bb-global-search-placeholder-color: #a88dbc
        --bb-global-search-item-bg: #6522cc
        --bb-global-search-item-active-bg: rgba(var(--bb-primary-color-rgb), 0.5)
        --bb-global-search-item-hover-bg: rgba(var(--bb-primary-color-rgb), 0.4)
        --bb-global-search-dialog-input-focus-border-color: var(--bb-primary-color)
    }

    class HeaderRazorCSS {
        --bb-global-search-item-active-bg: rgba(var(--bb-primary-color-rgb), 0.5)
        --bb-global-search-item-hover-bg: rgba(var(--bb-primary-color-rgb), 0.4)
        --bb-global-search-dialog-input-focus-border-color: var(--bb-primary-color)
    }

    note for SiteCSS "Variables moved to this class for better organization"
    note for HeaderRazorCSS "Variables removed from this class"
Loading

File-Level Changes

Change Details Files
Relocated search dialog CSS variables to improve style organization
  • Moved search-related CSS variables from Header component to site.css
  • Grouped search dialog variables under .search-dialog-mask selector
  • Removed ::deep .bb-g-search selector from Header component
src/BootstrapBlazor.Server/wwwroot/css/site.css
src/BootstrapBlazor.Server/Components/Components/Header.razor.css

Assessment against linked issues

Issue Objective Addressed Explanation
#4718 Update package styling for MeiliSearch component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 22, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang enabled auto-merge (squash) November 22, 2024 05:56
@codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbc8d1b) to head (35c45b8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4719   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27382     27382           
  Branches      3923      3923           
=========================================
  Hits         27382     27382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ArgoZhang ArgoZhang merged commit 57cb436 into main Nov 22, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the doc-search branch November 22, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(MeiliSearch): update package for style

2 participants