Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Nov 23, 2024

use server render instead of client render

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4722
close #4710

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Refactor the Checkbox component to utilize server-side rendering, replacing client-side rendering. Update associated unit tests to align with the new rendering logic.

Enhancements:

  • Refactor Checkbox component to use server-side rendering instead of client-side rendering.

Tests:

  • Update unit tests to reflect changes in Checkbox component's rendering logic.

@bb-auto bb-auto bot added the enhancement New feature or request label Nov 23, 2024
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 23, 2024

Reviewer's Guide by Sourcery

This PR refactors the Checkbox component to use server-side rendering instead of client-side rendering. The main changes involve removing JavaScript-based state management and DOM manipulation in favor of Blazor's built-in rendering capabilities.

Sequence diagram for Checkbox state change

sequenceDiagram
    participant User
    participant Checkbox
    participant BlazorServer

    User->>Checkbox: Click Checkbox
    Checkbox->>BlazorServer: OnToggleClick()
    BlazorServer->>Checkbox: Update State
    Checkbox->>User: Render Updated State
Loading

File-Level Changes

Change Details Files
Refactored checkbox state management from client-side to server-side
  • Removed JavaScript-based state management and DOM manipulation
  • Added server-side state tracking through component properties
  • Replaced custom click handling with Blazor's built-in event handling
  • Removed CSS class manipulation from JavaScript
  • Added direct state synchronization between server and client
src/BootstrapBlazor/Components/Checkbox/Checkbox.razor.cs
src/BootstrapBlazor/Components/Checkbox/Checkbox.razor
src/BootstrapBlazor/Components/Checkbox/Checkbox.razor.js
Updated method names and signatures for better clarity
  • Renamed TriggerClick to OnToggleClick for better semantics
  • Updated method signatures to align with server-side rendering approach
  • Simplified state change handling logic
src/BootstrapBlazor/Components/Checkbox/Checkbox.razor.cs
Updated test cases to reflect new checkbox behavior
  • Updated test assertions to check for new state management approach
  • Modified test method calls to use new method names
  • Added tests for server-side state handling
test/UnitTest/Components/CheckboxListTest.cs
test/UnitTest/Components/TableTest.cs
test/UnitTest/Components/TreeViewTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4722 Refactor Checkbox component to use server-side rendering instead of client-side rendering

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Nov 23, 2024
@ArgoZhang
Copy link
Member Author

@sourcery-ai review

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Nov 23, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 2 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang enabled auto-merge (squash) November 23, 2024 05:27
@ArgoZhang
Copy link
Member Author

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟡 Testing: 2 issues found
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (57cb436) to head (8789bdc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4723   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27382     27368   -14     
  Branches      3923      3919    -4     
=========================================
- Hits         27382     27368   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ArgoZhang ArgoZhang merged commit 3f3bb1a into main Nov 23, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the refactor-checkbox branch November 23, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(Checkbox): use server render instead of client render bug(Checkbox): Checkbox在WebAssembly模式下不显示选中状态

2 participants