Skip to content

feat(TreeView): use Task instead of ValueTask #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2024
Merged

feat(TreeView): use Task instead of ValueTask #4737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31cb69e
refactor(TreeView): use Task instead of ValueTask
ArgoZhang Nov 25, 2024
98ae8dc
chore: bump version 9.0.2-beta03
ArgoZhang Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/BootstrapBlazor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>9.0.2-beta02</Version>
<Version>9.0.2-beta03</Version>
</PropertyGroup>

<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/BootstrapBlazor/Components/TreeView/TreeView.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ public async ValueTask TriggerKeyDown(string key)
/// <param name="items"></param>
/// <returns></returns>
[JSInvokable]
public ValueTask<List<CheckboxState>> GetParentsState(List<int> items)
public Task<List<CheckboxState>> GetParentsState(List<int> items)
{
var rows = Rows;
var result = items.Select(i =>
Expand All @@ -447,7 +447,7 @@ public ValueTask<List<CheckboxState>> GetParentsState(List<int> items)
item.CheckedState = checkedState;
return checkedState;
}).ToList();
return ValueTask.FromResult(result);
return Task.FromResult(result);
}

private static bool IsExpand(TreeViewItem<TItem> item) => item.IsExpand && item.Items.Count > 0;
Expand Down