doc(Icon): remove IconList component #4793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis PR removes the IconList components for various icon libraries (FontAwesome, AntDesign, ElementUI, IconPark) and replaces them with direct links to the official icon documentation. The implementation simplifies the icon documentation by removing local icon listings and instead directing users to the respective icon library websites. Class diagram for removed IconList componentsclassDiagram
class FAIcons {
- bool ShowCopyDialog
- string DisplayText
}
class AntDesignIconList
class ElementIconList
class FAIconList
class IconParkList
FAIcons --> AntDesignIconList : removed
FAIcons --> ElementIconList : removed
FAIcons --> FAIconList : removed
FAIcons --> IconParkList : removed
note for FAIcons "ShowCopyDialog and DisplayText attributes removed"
note for AntDesignIconList "Component removed"
note for ElementIconList "Component removed"
note for FAIconList "Component removed"
note for IconParkList "Component removed"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4793 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27425 27425
Branches 3925 3925
=========================================
Hits 27425 27425 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove IconList component
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #4792
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Remove the IconList component and replace its usage with direct HTML markup for displaying icon information. Fix incorrect URLs in icon information links to point directly to the icon list. Update documentation links to ensure they direct users to the correct icon list pages.
Bug Fixes:
Enhancements:
Documentation: