Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Dec 8, 2024

update layout-menu style

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4802

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the layout menu style and rendering logic to fix display issues and enhance assembly management by adding the 'AdditionalAssemblies' attribute to Layout components.

Bug Fixes:

  • Fix the layout menu rendering logic to ensure proper display when certain conditions are met.

Enhancements:

  • Add 'AdditionalAssemblies' attribute to Layout components for improved assembly management.

@bb-auto bb-auto bot added the enhancement New feature or request label Dec 8, 2024
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 8, 2024

Reviewer's Guide by Sourcery

The PR updates the Layout component to handle menu scrolling behavior more consistently by introducing AdditionalAssemblies parameter and modifying the menu rendering logic. The changes also include style updates to properly handle menu height in fixed tab layouts.

Class diagram for updated Layout component

classDiagram
    class Layout {
        +bool ShowFooter
        +bool IsFullSide
        +int SideWidth
        +Menu[] Menus
        +RenderFragment Header
        +RenderFragment RenderMenu
        +RenderFragment RenderMain
        +Assembly[] AdditionalAssemblies
    }
    note for Layout "Updated RenderMenu logic and added AdditionalAssemblies parameter"
Loading

File-Level Changes

Change Details Files
Modified menu rendering logic to simplify scroll behavior determination
  • Removed hasScroll parameter from RenderMenu fragment
  • Changed scroll condition to use IsFixedTabHeader or IsFullSide flags
  • Simplified menu rendering calls by removing unnecessary parameter
src/BootstrapBlazor/Components/Layout/Layout.razor
Added AdditionalAssemblies parameter to Layout component instances
  • Added AdditionalAssemblies parameter with MainLayout.Assembly value to all Layout component usages
src/BootstrapBlazor.Shared/Components/Samples/Layouts.razor
Updated CSS styles for layout menu height calculations
  • Added height calculation for layout-menu in fixed tab layouts
  • Added height calculation for layout-menu in full-side layouts
src/BootstrapBlazor/Components/Layout/Layout.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#4802 Update layout-menu style to fix height calculations in different layout scenarios

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 8, 2024
@ArgoZhang ArgoZhang enabled auto-merge (squash) December 8, 2024 05:47
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please properly fill out the PR template with a clear description of the changes, their purpose, and mark the appropriate checkboxes. This will help with review and future maintenance.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4801b7b) to head (d3e2e1f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4803   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27415     27333   -82     
  Branches      3922      3921    -1     
=========================================
- Hits         27415     27333   -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 1972c70 into main Dec 8, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-menu branch December 8, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(Layout): update layout-menu style

2 participants