-
-
Notifications
You must be signed in to change notification settings - Fork 364
fix(Layout): update layout-menu style #4803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe PR updates the Layout component to handle menu scrolling behavior more consistently by introducing AdditionalAssemblies parameter and modifying the menu rendering logic. The changes also include style updates to properly handle menu height in fixed tab layouts. Class diagram for updated Layout componentclassDiagram
class Layout {
+bool ShowFooter
+bool IsFullSide
+int SideWidth
+Menu[] Menus
+RenderFragment Header
+RenderFragment RenderMenu
+RenderFragment RenderMain
+Assembly[] AdditionalAssemblies
}
note for Layout "Updated RenderMenu logic and added AdditionalAssemblies parameter"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please properly fill out the PR template with a clear description of the changes, their purpose, and mark the appropriate checkboxes. This will help with review and future maintenance.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 620 620
Lines 27415 27333 -82
Branches 3922 3921 -1
=========================================
- Hits 27415 27333 -82 ☔ View full report in Codecov by Sentry. |
update layout-menu style
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4802
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the layout menu style and rendering logic to fix display issues and enhance assembly management by adding the 'AdditionalAssemblies' attribute to Layout components.
Bug Fixes:
Enhancements: