Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Dec 10, 2024

update project toolchain

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4810

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the Nginx configuration to improve server handling and security, modify deployment scripts for .NET 9.0, and enhance the bug report template with a dropdown for .NET versions.

Build:

  • Update the .NET version options in the bug report issue template to include a dropdown with versions NET9.0, NET8.0, NET7.0, and NET6.0.

Deployment:

  • Modify the deploy-blazor.sh script to publish the project using .NET 9.0 instead of .NET 8.0.

@bb-auto bb-auto bot added the chore This are tasks or bot action label Dec 10, 2024
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 10, 2024

Reviewer's Guide by Sourcery

This PR updates the project toolchain by modifying the Nginx configuration, deployment scripts, and issue template. The changes include improved SSL/HTTPS handling, updated deployment processes, and a more structured .NET version selection in bug reports.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Enhanced Nginx configuration with improved SSL and error handling
  • Added dedicated SSL configuration for both www and non-www domains
  • Updated SSL certificate paths and locations
  • Improved error handling with custom error pages
  • Removed redundant server configurations
  • Updated proxy settings and headers
scripts/linux/nginx.conf
Updated deployment script for newer .NET version and improved deployment flow
  • Changed target framework from net8.0 to net9.0
  • Reordered deployment steps for better process flow
  • Added status check after service restart
scripts/linux/deploy-blazor.sh
Improved bug report template with structured .NET version selection
  • Replaced free-form input with dropdown selection for .NET versions
  • Added options for NET6.0 through NET9.0
  • Set NET8.0 as the default selection
.github/ISSUE_TEMPLATE/10_bug_report.yml
Removed deprecated deployment script
  • Removed WASM-specific deployment script
scripts/linux/deploy-wasm.sh

Assessment against linked issues

Issue Objective Addressed Explanation
#4810 Update project toolchain configuration files and scripts

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 10, 2024
@ArgoZhang ArgoZhang enabled auto-merge (squash) December 10, 2024 02:19
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please document the .NET 9 migration strategy and any potential breaking changes or requirements. This is a significant version upgrade that needs more context.
  • The PR description template needs to be properly filled out, particularly the risk assessment section, given this involves deployment infrastructure changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8b9a4a8) to head (034121c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4811   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       620           
  Lines        27333     27333           
  Branches      3921      3921           
=========================================
  Hits         27333     27333           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 1aa380d into main Dec 10, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the chore-config branch December 10, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Config): update project toolchain

2 participants