-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(Split): add SetLeftWidth method #4818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR implements a new SetLeftWidth method for the Split component, allowing dynamic control of the left pane's width. The implementation includes JavaScript interop to modify the flex-basis property of the left pane, along with corresponding C# method and demo updates. Sequence diagram for SetLeftWidth method invocationsequenceDiagram
actor User
participant DemoBlock
participant Split
participant JavaScript
User->>DemoBlock: Click Button (e.g., "25%")
DemoBlock->>Split: OnSetLeft("25%")
Split->>JavaScript: setLeft(Id, "25%")
JavaScript-->>Split: Update flex-basis
Split-->>DemoBlock: Completion
DemoBlock-->>User: UI Updated
Class diagram for the Split component with SetLeftWidth methodclassDiagram
class Split {
+Task SetLeftWidth(string leftWidth)
}
note for Split "The SetLeftWidth method allows setting the left pane's width dynamically."
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4818 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 621 621
Lines 27410 27411 +1
Branches 3930 3930
=========================================
+ Hits 27410 27411 +1 ☔ View full report in Codecov by Sentry. |
add SetLeftWidth method
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4815
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add the SetLeftWidth method to the Split component to enable setting the left pane's width, and include a corresponding unit test to ensure its functionality.
New Features:
Tests: