Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Dec 13, 2024

revert Select component update

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4843

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Revert the Select component to a previous version, removing the generic Select component and its associated tests and documentation.

Bug Fixes:

  • Fix the issue with the Select component by reverting to a previous stable version.

Enhancements:

  • Remove the generic Select component and its related files, simplifying the codebase.

Documentation:

  • Update documentation to remove references to the generic Select component.

Tests:

  • Update unit tests to reflect the changes in the Select component, removing tests related to the generic version.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 13, 2024

Reviewer's Guide by Sourcery

This PR reverts changes made to the Select component, removing the generic implementation and consolidating back to a single non-generic version. The changes primarily involve removing SelectGeneric-related files and code, while updating tests and samples to use the non-generic Select component.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Remove generic implementation of Select component
  • Delete SelectGeneric component files and related interfaces
  • Remove SelectedItem generic class
  • Update unit tests to use non-generic Select component
  • Remove generic-specific functionality like ValueEqualityComparer and CustomKeyAttribute
src/BootstrapBlazor/Components/SelectGeneric/ISelectGeneric.cs
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor.cs
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor.js
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor.scss
src/BootstrapBlazor/Components/SelectGeneric/SelectOptionGeneric.cs
src/BootstrapBlazor/Misc/SelectedItemOfT.cs
Update Select component implementation
  • Remove IModelEqualityComparer interface implementation
  • Remove TextConvertToValueCallback functionality
  • Simplify value handling and comparison logic
  • Update component parameters and event handlers
src/BootstrapBlazor/Components/Select/Select.razor.cs
Update test cases for Select component
  • Replace SelectGeneric with Select in test assertions
  • Update test data structures to use non-generic SelectedItem
  • Remove generic-specific test cases
  • Add new test cases for basic Select functionality
test/UnitTest/Components/SelectTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4843 Revert the Select component update by removing the generic version of Select component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the chore This are tasks or bot action label Dec 13, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 13, 2024
@ArgoZhang ArgoZhang merged commit 41dbb19 into main Dec 13, 2024
3 checks passed
@ArgoZhang ArgoZhang deleted the refactor-select branch December 13, 2024 12:26
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (56e8e74) to head (8b1f955).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4844   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          620       619    -1     
  Lines        27402     27368   -34     
  Branches      3924      3923    -1     
=========================================
- Hits         27402     27368   -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Select): revert Select component update

2 participants