Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Dec 14, 2024

add SelectGeneric component

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4845

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add a new SelectGeneric component with features like search, clearable options, and virtual scrolling, and enhance EnumExtensions to support generic enum conversion. Include extensive unit tests for the new component.

New Features:

  • Introduce a new SelectGeneric component that provides a generic select input with support for various features like search, clearable options, and virtual scrolling.

Enhancements:

  • Enhance EnumExtensions with a new method to convert enum types to a list of SelectedItem with generic support.

Tests:

  • Add comprehensive unit tests for the SelectGeneric component, covering various scenarios including search functionality, item selection, and virtual scrolling.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 14, 2024

Reviewer's Guide by Sourcery

This PR adds a new SelectGeneric component that provides a generic implementation of a dropdown select control with features like search, virtualization, and custom templates.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Implement core SelectGeneric component with generic type support
  • Add base SelectGeneric component with generic type parameter TValue
  • Implement dropdown selection functionality with single item selection
  • Add support for disabled items and clear button functionality
  • Add validation support with form integration
  • Implement custom value comparison logic for complex types
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor.cs
src/BootstrapBlazor/Components/SelectGeneric/ISelectGeneric.cs
Add search and virtualization capabilities
  • Implement search functionality with text filtering
  • Add virtualization support for large datasets
  • Add fixed search option for better UX
  • Implement async data loading with virtualization
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor.cs
Add templating and customization features
  • Add item template support for custom item rendering
  • Add display template for custom selected value display
  • Add group template support for grouped items
  • Implement custom styling and theming options
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor
src/BootstrapBlazor/Components/SelectGeneric/SelectGeneric.razor.scss
Add support components and models
  • Add SelectOptionGeneric component for declarative options
  • Add SelectedItem model for generic value support
  • Add unit tests covering component functionality
  • Add enum extension support for automatic enum options
src/BootstrapBlazor/Components/SelectGeneric/SelectOptionGeneric.cs
src/BootstrapBlazor/Misc/SelectedItemOfT.cs
test/UnitTest/Components/SelectGenericTest.cs
src/BootstrapBlazor/Extensions/EnumExtensions.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#4845 Add SelectGeneric component

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Dec 14, 2024
@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 14, 2024
@ArgoZhang ArgoZhang enabled auto-merge (squash) December 14, 2024 07:56
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Dec 14, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding XML documentation comments for public methods and properties to improve API documentation
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang disabled auto-merge December 14, 2024 09:59
@ArgoZhang ArgoZhang merged commit f96b827 into main Dec 14, 2024
2 of 3 checks passed
@ArgoZhang ArgoZhang deleted the feat-select-generic branch December 14, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(SelectGeneric): add SelectGeneric component

2 participants