-
-
Notifications
You must be signed in to change notification settings - Fork 365
fix(Select): add composition support #4847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR adds composition support to the Select component by implementing IME input handling and reorganizing the search functionality. The changes include debouncing search input, handling composition events, and restructuring the component's initialization and event handling. Sequence diagram for Select component initializationsequenceDiagram
participant User
participant SelectComponent
participant JSInterop
participant EventHandler
User->>SelectComponent: Initialize Select
SelectComponent->>JSInterop: Invoke init with options
JSInterop->>EventHandler: Set up event listeners
EventHandler->>SelectComponent: Handle input and composition events
Updated class diagram for Select componentclassDiagram
class SelectComponent {
+Task InvokeInitAsync()
+Task ConfirmSelectedItem(int index)
+Task TriggerOnSearch(string searchText)
-Task SearchTextChanged(string val)
-ValueTask<ItemsProviderResult<SelectedItem>> LoadItems(ItemsProviderRequest request)
}
note for SelectComponent "Added TriggerOnSearch method for handling search input from JS"
note for SelectComponent "Modified InvokeInitAsync to pass options object with callbacks"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding documentation explaining what composition support means and why it's needed for IME input in the PR description
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
add composition support
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4826
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add composition event support to the Select component to fix issue #4826 and improve search input handling with debounce functionality.
Bug Fixes:
Enhancements: