-
-
Notifications
You must be signed in to change notification settings - Fork 364
fix(Dropdown): not show dropdown menu after toggle IsDisabled parameter #4848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe PR fixes a dropdown menu visibility issue by removing the conditional rendering based on IsDisabled. The dropdown menu's HTML structure is now always rendered, while the disabled state is controlled through the button's disabled attribute. Class diagram for Dropdown component changesclassDiagram
class Dropdown {
- bool IsDisabled
+ void OnItemClick(item)
+ string ActiveItem(item)
+ IEnumerable<Item> GetItems()
+ RenderFragment ItemTemplate
+ RenderFragment ItemsTemplate
}
note for Dropdown "Removed conditional rendering based on IsDisabled."
note for Dropdown "Dropdown menu is always rendered, controlled by button's disabled attribute."
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider handling the disabled state through Bootstrap's CSS classes and attributes rather than conditional rendering for better maintainability and consistency with Bootstrap patterns.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4848 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 619 623 +4
Lines 27368 27807 +439
Branches 3923 3980 +57
==========================================
+ Hits 27368 27807 +439 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Argo Zhang <[email protected]>
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
not show dropdown menu after toggle IsDisabled parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4842
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: