Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Dec 14, 2024

not show dropdown menu after toggle IsDisabled parameter

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4842

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fix the issue where the dropdown menu was incorrectly displayed after toggling the IsDisabled parameter.

@bb-auto bb-auto bot added the bug Something isn't working label Dec 14, 2024
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 14, 2024

Reviewer's Guide by Sourcery

The PR fixes a dropdown menu visibility issue by removing the conditional rendering based on IsDisabled. The dropdown menu's HTML structure is now always rendered, while the disabled state is controlled through the button's disabled attribute.

Class diagram for Dropdown component changes

classDiagram
    class Dropdown {
        - bool IsDisabled
        + void OnItemClick(item)
        + string ActiveItem(item)
        + IEnumerable<Item> GetItems()
        + RenderFragment ItemTemplate
        + RenderFragment ItemsTemplate
    }
    note for Dropdown "Removed conditional rendering based on IsDisabled."
    note for Dropdown "Dropdown menu is always rendered, controlled by button's disabled attribute."
Loading

File-Level Changes

Change Details Files
Restructured dropdown menu rendering logic
  • Removed IsDisabled conditional wrapper around the dropdown menu div
  • Preserved the inner menu content rendering logic
  • Maintained button disabled state handling through the disabled attribute
src/BootstrapBlazor/Components/Dropdown/Dropdown.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#4842 Fix dropdown menu not showing after toggling IsDisabled from true to false

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.0.0 milestone Dec 14, 2024
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Dec 14, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider handling the disabled state through Bootstrap's CSS classes and attributes rather than conditional rendering for better maintainability and consistency with Bootstrap patterns.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (41dbb19) to head (d9bb475).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #4848    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          619       623     +4     
  Lines        27368     27807   +439     
  Branches      3923      3980    +57     
==========================================
+ Hits         27368     27807   +439     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang
Copy link
Member Author

@sourcery-ai review

@ArgoZhang ArgoZhang enabled auto-merge (squash) December 14, 2024 10:02
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Dec 14, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang disabled auto-merge December 14, 2024 10:34
@ArgoZhang ArgoZhang merged commit c673833 into main Dec 14, 2024
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-dropdown branch December 14, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Dropdown): 组件设置IsDisabled=true之后,再设置IsDisabled=false。下拉框无法弹出

2 participants