-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(SelectTree): add IsReset parameter #4863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe PR adds a new IsReset parameter to the SelectTree component and propagates it to the underlying TreeView component. This parameter controls whether loaded data should be reset on page refresh. Class diagram for SelectTree component with IsReset parameterclassDiagram
class SelectTree {
+bool IsEditable
+bool IsReset
+IStringLocalizer~SelectTree~ Localizer
}
note for SelectTree "IsReset is a new parameter added to control data reset on page refresh."
Class diagram for TreeView component with IsReset parameterclassDiagram
class TreeView {
+TValue Items
+bool IsReset
+bool ShowIcon
+OnTreeItemClick
+ModelEqualityComparer
+CustomKeyAttribute
+OnExpandNodeAsync
}
note for TreeView "IsReset parameter is propagated from SelectTree to TreeView."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Thanks for your PR, @tiansfather. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tiansfather - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR template with details about the bug being fixed, risk assessment, and verification steps. This will help reviewers understand the context and impact of the change.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4863 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 623 623
Lines 27831 27832 +1
Branches 3982 3982
=========================================
+ Hits 27831 27832 +1 ☔ View full report in Codecov by Sentry. |
add IsReset parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4867
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features: