feat(GotoTop): add ScrollBehavior parameter #4885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis PR adds a ScrollBehavior parameter to the GoTop component, allowing customization of the scroll animation behavior. The implementation includes updates to the component's parameters, markup, and JavaScript code to support both smooth and auto scroll behaviors. Sequence diagram for GoTop component scroll behaviorsequenceDiagram
actor User
participant GoTopComponent as GoTop Component
participant JSFunction as JavaScript Function
User->>GoTopComponent: Click GoTop button
GoTopComponent->>JSFunction: init(id, target)
JSFunction->>JSFunction: Get data-bb-target and data-bb-behavior
JSFunction->>JSFunction: element.scrollTo({ top: 0, left: 0, behavior: behavior })
JSFunction-->>User: Scroll to top with specified behavior
Class diagram for GoTop component with ScrollBehaviorclassDiagram
class GoTop {
+string? Target
+ScrollIntoViewBehavior ScrollBehavior
+string? TooltipText
-IIconTheme? IconTheme
-string? ScrollBehaviorString
}
note for GoTop "Added ScrollBehavior parameter and ScrollBehaviorString property"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide a more detailed English description of the changes and complete the PR template sections (particularly risk assessment and verification details).
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4885 +/- ##
========================================
Coverage 99.99% 100.00%
========================================
Files 623 623
Lines 27832 27834 +2
Branches 3983 3984 +1
========================================
+ Hits 27831 27834 +3
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ScrollBehavior parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #4884
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a ScrollBehavior parameter to the GoTop component to allow customization of scroll behavior, and update the component to handle this new parameter. Enhance the component's functionality by supporting different scroll behaviors and add corresponding unit tests to verify the implementation.
New Features:
Enhancements:
Tests: