-
-
Notifications
You must be signed in to change notification settings - Fork 363
fix(TableColumn): GetTooltipTextCallback not work #4893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR fixes an issue with tooltip functionality in the Table component by replacing the synchronous GetTooltipText with an asynchronous GetTooltipTextCallback implementation. The changes include updating the Tooltip component to handle async callbacks and removing deprecated code. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4893 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 623 623
Lines 27834 27846 +12
Branches 3990 3993 +3
=========================================
+ Hits 27834 27846 +12 ☔ View full report in Codecov by Sentry. |
GetTooltipTextCallback not work
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4888
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix the tooltip text callback functionality by replacing the synchronous GetTooltipText method with the asynchronous GetTooltipTextCallback method across the codebase. Update related unit tests to ensure the new callback method is properly tested.
Bug Fixes:
Enhancements:
Tests: