-
-
Notifications
You must be signed in to change notification settings - Fork 364
refactor(TreeView): update clear cache logic #4955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: XiaoChenDan <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-Authored-By: XiaoChenDan <[email protected]>
Reviewer's Guide by SourceryThis PR refactors the TreeView component to update the clear cache logic and improves scrolling behavior. Sequence diagram for TreeView cache clearing and scrollingsequenceDiagram
participant TV as TreeView
participant Cache as TreeNodeStateCache
participant Ext as TreeViewExtensions
TV->>Cache: Reset()
Note over TV: Parameters Set
TV->>Ext: ToFlat(items, parent)
Note over Ext: Build flat list<br/>with parent refs
TV->>TV: GetTreeItems()
Note over TV: Get items from<br/>search or main list
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4955 +/- ##
===========================================
+ Coverage 99.96% 100.00% +0.03%
===========================================
Files 584 629 +45
Lines 24876 28093 +3217
Branches 3600 4035 +435
===========================================
+ Hits 24867 28093 +3226
+ Misses 4 0 -4
+ Partials 5 0 -5 ☔ View full report in Codecov by Sentry. |
update clear cache logic
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4954
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the tree view to improve scrolling behavior and cache clearing logic.
Enhancements:
scrollIntoViewAPI.