-
-
Notifications
You must be signed in to change notification settings - Fork 364
doc(TreeView): update skeleton documentation #4960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Tony Guo <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-Authored-By: Tony Guo <[email protected]>
Reviewer's Guide by SourceryThis PR updates the documentation for the TreeView component to include information about the skeleton functionality. It also modifies the sample code to demonstrate the skeleton feature. Sequence diagram for TreeView skeleton loading processsequenceDiagram
participant User
participant Button
participant TreeView
participant Server
User->>Button: Click load button
Button->>TreeView: Trigger async load
activate TreeView
Note over TreeView: Show skeleton loading state
TreeView->>Server: OnLoadAsyncItems()
Server-->>TreeView: Return async items
TreeView->>TreeView: Update with real data
deactivate TreeView
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4960 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 629 629
Lines 28096 28096
Branches 4035 4035
=========================================
Hits 28096 28096 ☔ View full report in Codecov by Sentry. |
update skeleton documentation
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4959
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the TreeView sample to use the new
ignoreattribute for skeleton loading.New Features:
ignoreattribute in the TreeView component to control skeleton loading behavior.Documentation: