-
-
Notifications
You must be signed in to change notification settings - Fork 365
feat(Drawer): add Component parameter on DrawerOption #4964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: MadLongTom <[email protected]> Co-Authored-By: Frost Autumn <[email protected]> Co-Authored-By: ice6 <[email protected]>
Co-Authored-By: Alex chow <[email protected]>
Reviewer's Guide by SourceryThis pull request introduces a new Sequence diagram for Drawer content renderingsequenceDiagram
participant DC as DrawerContainer
participant DO as DrawerOption
participant DE as DrawerOptionExtensions
DC->>DO: GetParameters()
DO->>DE: GetContent()
alt ChildContent exists
DE-->>DC: Return ChildContent
else Component exists
DE-->>DC: Return Component.Render()
else Neither exists
DE-->>DC: Return null
end
Note over DC: Add content to parameters
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding English documentation for the new Component parameter to improve accessibility for non-Chinese speaking developers.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4964 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 629 630 +1
Lines 28096 28099 +3
Branches 4035 4036 +1
=========================================
+ Hits 28096 28099 +3 ☔ View full report in Codecov by Sentry. |
add Component parameter on DrawerOption
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4961
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features:
Componentparameter.