-
-
Notifications
You must be signed in to change notification settings - Fork 364
refactor(Select): reuse input composing function #4971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: SamXMG <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-Authored-By: SamXMG <[email protected]>
Reviewer's Guide by SourceryThis PR refactors the Select component to reuse the input composing function. Sequence diagram for input composition handling in Select componentsequenceDiagram
participant User
participant Select
participant Input
participant EventHandler
Note over User,EventHandler: New implementation using Input module
User->>Select: Type Chinese character
Select->>Input: composition(search, callback)
Input->>EventHandler: Register composition events
User->>EventHandler: compositionstart
EventHandler->>Input: Set isComposing = true
User->>EventHandler: input event
EventHandler->>Input: Check isComposing
Note over Input: Skip callback if composing
User->>EventHandler: compositionend
EventHandler->>Input: Set isComposing = false
Input->>Select: Execute callback with value
Class diagram showing refactored input handlingclassDiagram
class Select {
-id: string
-invoke: object
-options: object
+init(id, invoke, options)
+show(id)
+dispose(id)
}
class Input {
+composition(el, callback)
+dispose(el)
}
class EventHandler {
+on(element, event, handler)
+off(element, event)
}
Select --> Input : uses
Select --> EventHandler : uses
Input --> EventHandler : uses
note for Input "Reusable input composition handling"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This reverts commit b9f6deb. # Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4971 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 630 630
Lines 28099 28099
Branches 4036 4036
=========================================
Hits 28099 28099 ☔ View full report in Codecov by Sentry. |
reuse input composing function
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4970
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: