-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(ScrollIntoViewBehavior): add Description attribute #4989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds a Description attribute to the ScrollIntoViewBehavior, ScrollIntoViewBlock, and ScrollIntoViewInline enums. Class diagram showing updated enums with Description attributesclassDiagram
class ScrollIntoViewBehavior {
<<enumeration>>
+Smooth [Description("smooth")]
+Instant [Description("instant")]
+Auto [Description("auto")]
}
class ScrollIntoViewBlock {
<<enumeration>>
+Start [Description("start")]
+Center [Description("center")]
+End [Description("end")]
+Nearest [Description("nearest")]
}
class ScrollIntoViewInline {
<<enumeration>>
+Start [Description("start")]
+Center [Description("center")]
+End [Description("end")]
+Nearest [Description("nearest")]
}
note for ScrollIntoViewBehavior "Added Description attributes"
note for ScrollIntoViewBlock "Added Description attributes"
note for ScrollIntoViewInline "Added Description attributes"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4989 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 630 630
Lines 28077 28077
Branches 4026 4026
=========================================
Hits 28077 28077 ☔ View full report in Codecov by Sentry. |
Co-Authored-By: zph19970424 <[email protected]>
add Description attribute
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4988
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
New Features:
ScrollIntoViewOptionsenum members.