-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat(Search): OnSearch callback support async #5000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe pull request refactors the Search component to support a generic type parameter and an async OnSearch callback, allowing for more flexible and dynamic search operations. It also updates related unit tests and sample components to align with these changes. Additionally, the AutoFill component's Template parameter is deprecated in favor of ItemTemplate, and the OnSearch method in the Coms component is adjusted to handle nullable strings. Sequence diagram for Search component interactionsequenceDiagram
participant U as User
participant S as Search~TValue~
participant C as OnSearch Callback
U->>S: Enter search text
S->>S: Update _displayText
U->>S: Click search button
S->>S: Set loading icon
S->>C: OnSearch(_displayText)
C-->>S: Return IEnumerable~TValue~
S->>S: Update FilterItems
S->>S: Reset button icon
alt IsAutoClearAfterSearch is true
S->>S: Clear _displayText
end
S->>S: Show filtered items
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5000 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 630 630
Lines 27907 27917 +10
Branches 3991 3993 +2
=========================================
+ Hits 27907 27917 +10 ☔ View full report in Codecov by Sentry. |
OnSearch callback support async
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #4967
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add async support to the OnSearch callback in the Search component and introduce a generic type parameter for enhanced type safety. Update related unit tests to reflect these changes.
New Features:
Enhancements:
Tests: