-
-
Notifications
You must be signed in to change notification settings - Fork 364
feat(IIconTheme): use FrozenDictionary improve performance #5008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Alex chow <[email protected]>
Reviewer's Guide by SourceryThis pull request improves performance by using FrozenDictionary to store icon themes when running on .NET 8 or higher. Class diagram showing IconTheme changes for .NET 8classDiagram
class IIconTheme {
<<interface>>
+GetIcons() Dictionary~ComponentIcons, string~
+GetIcons() FrozenDictionary~ComponentIcons, string~
}
class DefaultIconTheme {
-IOptions~IconThemeOptions~ _options
+GetIcons() Dictionary~ComponentIcons, string~
+GetIcons() FrozenDictionary~ComponentIcons, string~
}
class IconThemeOptions {
+Icons Dictionary~string, Dictionary~ComponentIcons, string~~
+Icons FrozenDictionary~string, FrozenDictionary~ComponentIcons, string~~
+ThemeKey string
}
class FontAwesomeIcons {
+Icons Dictionary~ComponentIcons, string~
+ToFrozenDictionary() FrozenDictionary~ComponentIcons, string~
}
IIconTheme <|.. DefaultIconTheme
DefaultIconTheme --> IconThemeOptions
IconThemeOptions --> FontAwesomeIcons
note for IconThemeOptions "Uses FrozenDictionary in .NET 8+"
note for DefaultIconTheme "Implements both Dictionary and FrozenDictionary versions"
State diagram showing IconTheme initialization flowstateDiagram-v2
[*] --> InitializeIconTheme
InitializeIconTheme --> CheckDotNetVersion
CheckDotNetVersion --> NET8: if .NET 8+
CheckDotNetVersion --> OlderVersion: if < .NET 8
NET8 --> CreateFrozenDictionary
OlderVersion --> CreateRegularDictionary
CreateFrozenDictionary --> [*]
CreateRegularDictionary --> [*]
note right of NET8: Uses FrozenDictionary for better performance
note right of OlderVersion: Uses regular Dictionary
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5008 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 630 631 +1
Lines 27928 27938 +10
Branches 3996 3998 +2
=========================================
+ Hits 27928 27938 +10 ☔ View full report in Codecov by Sentry. |
use FrozenDictionary improve performance
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5007
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve performance by using FrozenDictionary for icon themes in .NET 8 and later.
New Features:
Enhancements: