-
-
Notifications
You must be signed in to change notification settings - Fork 363
doc(MindMap): update documentation for callback extensions #5012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR updates the documentation for callback extensions in the MindMap component. It also simplifies sample data and adds new features such as scaling and custom callbacks. Sequence diagram for MindMap custom callback interactionsequenceDiagram
participant C as Client
participant M as MindMap Component
participant J as JavaScript
C->>M: Click custom button
M->>J: Execute('clickCustom', 'args1')
J->>J: window.BootstrapBlazor.MindMap.callbacks.clickCustom(args)
Note over J: Log args to console
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please add documentation explaining how to use the new JavaScript callback functionality, including examples of common use cases.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5012 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27938 27938
Branches 3998 3998
=========================================
Hits 27938 27938 ☔ View full report in Codecov by Sentry. |
update documentation for callback extensions
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5011
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the MindMap component to support custom callbacks and add sample code demonstrating their usage.
New Features:
Enhancements:
Documentation: