-
-
Notifications
You must be signed in to change notification settings - Fork 364
fix(Select): ShowSearch not work when set IsVirtualize to true #5022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: 8FAway <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-Authored-By: 8FAway <[email protected]>
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR is missing the actual code changes. Please include the implementation that fixes the ShowSearch functionality with IsVirtual.
- Please provide a clear description of how the issue was fixed and add test cases to prevent regression.
- Consider maintaining a single language (English) throughout the PR description for better collaboration.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5022 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27946 27951 +5
Branches 4003 4004 +1
=========================================
+ Hits 27946 27951 +5 ☔ View full report in Codecov by Sentry. |
ShowSearch not work when set IsVirtual to true
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5019
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: