-
-
Notifications
You must be signed in to change notification settings - Fork 364
refactor(ITableColumn): add nullable mark for Formatter parameter #5030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Alex chow <[email protected]> Co-Authored-By: MadLongTom <[email protected]>
Co-Authored-By: Zeus <[email protected]>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-Authored-By: Zeus <[email protected]>
Reviewer's Guide by SourceryThis pull request refactors the Class diagram showing number type checking methodsclassDiagram
class ObjectExtensions {
+IsNumber(Type t) bool
+IsNumberWithDotSeparator(Type t) bool
}
note for ObjectExtensions "IsNumber: Check numeric types regardless of culture
IsNumberWithDotSeparator: Check numeric types with dot separator"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using either CurrentCulture or CurrentUICulture consistently across IsNumber() and IsNumberWithDotSeparator() methods to avoid potential culture-related issues
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
# Conflicts: # test/UnitTest/Extensions/ObjectExtensionsTest.cs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5030 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27961 27961
Branches 4007 4007
=========================================
Hits 27961 27961 ☔ View full report in Codecov by Sentry. |
add nullable mark for Formatter parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5029
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the Formatter parameter of the ITableColumn interface to accept nullable objects.
Bug Fixes:
Enhancements: